Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2394853002: Fixes for presubmit recipe (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixes for presubmit recipe - Add depot_tools to PATH - Run on a branch - Use max verbosity BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2394853002 Committed: https://skia.googlesource.com/skia/+/3493e173328037ab313657bc05e47cd2bacb0d82

Patch Set 1 #

Patch Set 2 : Use a branch #

Patch Set 3 : Run 'git status', use max verbosity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -5 lines) Patch
M infra/bots/recipes/swarm_presubmit.py View 1 2 2 chunks +30 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_presubmit.expected/presubmit.json View 1 2 1 chunk +53 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
borenet
4 years, 2 months ago (2016-10-05 14:00:33 UTC) #4
rmistry
lgtm
4 years, 2 months ago (2016-10-05 14:27:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394853002/40001
4 years, 2 months ago (2016-10-05 14:28:12 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 14:29:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3493e173328037ab313657bc05e47cd2bacb0d82

Powered by Google App Engine
This is Rietveld 408576698