Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: infra/bots/recipes/swarm_presubmit.py

Issue 2394853002: Fixes for presubmit recipe (Closed)
Patch Set: Run 'git status', use max verbosity Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_presubmit.expected/presubmit.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipes/swarm_presubmit.py
diff --git a/infra/bots/recipes/swarm_presubmit.py b/infra/bots/recipes/swarm_presubmit.py
index 30155a2cd697bf3d16ef040d9995d1321772f954..ad4802501f53bd4a86d81bde5c97c9537f598557 100644
--- a/infra/bots/recipes/swarm_presubmit.py
+++ b/infra/bots/recipes/swarm_presubmit.py
@@ -8,8 +8,11 @@
DEPS = [
'core',
+ 'depot_tools/depot_tools',
+ 'recipe_engine/path',
'recipe_engine/properties',
'recipe_engine/step',
+ 'recipe_engine/uuid',
'vars',
]
@@ -17,9 +20,34 @@ DEPS = [
def RunSteps(api):
api.vars.setup()
api.core.checkout_steps()
- api.step('presubmit',
- cmd=['git', 'cl', 'presubmit', '--force'],
+
+ # git-cl wants us to be on a branch.
+ branch = 'tmp_%s' % api.uuid.random()
+ api.step('create git branch',
+ cmd=['git', 'checkout', '-b', branch],
cwd=api.vars.skia_dir)
+ try:
+ api.step('git status',
+ cmd=['git', 'status'],
+ cwd=api.vars.skia_dir)
+
+ depot_tools_path = api.depot_tools.package_repo_resource()
+ env = {'PATH': api.path.pathsep.join([str(depot_tools_path), '%(PATH)s'])}
+ api.step('presubmit',
+ cmd=['git', 'cl', 'presubmit', '--force', '-v', '-v'],
+ cwd=api.vars.skia_dir,
+ env=env)
+ finally:
+ api.step('git reset',
+ cmd=['git', 'reset', '--hard', 'origin/master'],
+ cwd=api.vars.skia_dir)
+ api.step('checkout origin/master',
+ cmd=['git', 'checkout', 'origin/master'],
+ cwd=api.vars.skia_dir)
+ api.step('delete git branch',
+ cmd=['git', 'branch', '-D', branch],
+ cwd=api.vars.skia_dir)
+
def GenTests(api):
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_presubmit.expected/presubmit.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698