Emit a compile-time error on members with the name of their enclosing class.

sdk/lib/_internal/compiler/implementation/warnings.dart

Index: sdk/lib/_internal/compiler/implementation/warnings.dart
diff --git a/sdk/lib/_internal/compiler/implementation/warnings.dart b/sdk/lib/_internal/compiler/implementation/warnings.dart
index bd06786f895183766f130b48cb048047c567f3ec..b1100a3fcd1f6f97a645748af18ea141c3d0ad0b 100644
--- a/sdk/lib/_internal/compiler/implementation/warnings.dart
+++ b/sdk/lib/_internal/compiler/implementation/warnings.dart
@@ -818,6 +818,19 @@ void main() {
   const c; // This constant variable must be initialized. 
 }"""]);
 
+  static const MessageKind MEMBER_USES_CLASS_NAME = const MessageKind(
+      "Error: Member can't have the same name as the class it is declared in.",

[Johnni Winther, 2013/09/20 06:57:36]

Member -> Members

[karlklose, 2013/09/20 07:54:28]

It is short for 'A member', and I think that is how we use it in the other
messages. Kept for consistency, but we should perhaps have a complete review of
the style of our messages.

Changed to 'member variable'.

+      howToFix: "Try renaming the variable.",

[Johnni Winther, 2013/09/20 06:57:36]

Do you know it is a variable? Couldn't it be a method?

[karlklose, 2013/09/20 07:54:28]

If it was a method, we would warn about the modifier/return type of the
constructor.

+      examples: const ["""
+class A { var A; }
+main() {
+  var a = new A();
+  a.A = 1;
+}
+""", """
+class A { static var A; }
+main() => A.A = 1;
+"""]);
 
   static const MessageKind WRONG_NUMBER_OF_ARGUMENTS_FOR_ASSERT =
       const MessageKind(