Emit a compile-time error on members with the name of their enclosing class.

sdk/lib/_internal/compiler/implementation/warnings.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 const DONT_KNOW_HOW_TO_FIX = "";
 
 /**
  * The messages in this file should meet the following guide lines:
@@ skipping 800 matching lines @@
 
   static const MessageKind CONST_WITHOUT_INITIALIZER = const MessageKind(
       "Error: A constant variable must be initialized.",
       howToFix: "Try adding an initializer or "
                 "removing the 'const' modifier.",
       examples: const ["""
 void main() {
   const c; // This constant variable must be initialized. 
 }"""]);
 
+  static const MessageKind MEMBER_USES_CLASS_NAME = const MessageKind(
+      "Error: Member can't have the same name as the class it is declared in.",

[Johnni Winther, 2013/09/20 06:57:36]

Member -> Members

[karlklose, 2013/09/20 07:54:28]

It is short for 'A member', and I think that is how we use it in the other
messages. Kept for consistency, but we should perhaps have a complete review of
the style of our messages.

Changed to 'member variable'.

+      howToFix: "Try renaming the variable.",

[Johnni Winther, 2013/09/20 06:57:36]

Do you know it is a variable? Couldn't it be a method?

[karlklose, 2013/09/20 07:54:28]

If it was a method, we would warn about the modifier/return type of the
constructor.

+      examples: const ["""
+class A { var A; }
+main() {
+  var a = new A();
+  a.A = 1;
+}
+""", """
+class A { static var A; }
+main() => A.A = 1;
+"""]);
 
   static const MessageKind WRONG_NUMBER_OF_ARGUMENTS_FOR_ASSERT =
       const MessageKind(
           'Error: Wrong number of arguments to assert. Should be 1, but given '
           '#{argumentCount}.');
 
   static const MessageKind ASSERT_IS_GIVEN_NAMED_ARGUMENTS = const MessageKind(
       'Error: "assert" takes no named arguments, but given #{argumentCount}.');
 
   static const MessageKind FACTORY_REDIRECTION_IN_NON_FACTORY =
@@ skipping 447 matching lines @@
 
 class CompileTimeConstantError extends Diagnostic {
   CompileTimeConstantError(MessageKind kind, Map arguments, bool terse)
     : super(kind, arguments, terse);
 }
 
 class CompilationError extends Diagnostic {
   CompilationError(MessageKind kind, Map arguments, bool terse)
     : super(kind, arguments, terse);
 }