Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: src/IceTargetLoweringMIPS32.h

Issue 2394773004: Subzero, MIPS32: Fix conditional mov instructions (Closed)
Patch Set: Fix typo in test file Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstMIPS32.cpp ('k') | tests_lit/assembler/mips32/encoding_intrinsics.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringMIPS32.h
diff --git a/src/IceTargetLoweringMIPS32.h b/src/IceTargetLoweringMIPS32.h
index fc39ab4df689b9afe2e4291fd42dc6fd419fc6eb..6d2d6a416056d8e71b17066109f8a2cd1188ba91 100644
--- a/src/IceTargetLoweringMIPS32.h
+++ b/src/IceTargetLoweringMIPS32.h
@@ -365,38 +365,36 @@ public:
Context.insert<InstMIPS32Mov_s>(Dest, Src);
}
- void _movf(Variable *Src0, Variable *Src1, Operand *FCC) {
- auto *Instr = Context.insert<InstMIPS32Movf>(Src0, Src1, FCC);
- Instr->setDestRedefined();
+ void _movf(Variable *Dest, Variable *Src0, Operand *FCC) {
+ Context.insert<InstMIPS32Movf>(Dest, Src0, FCC)->setDestRedefined();
}
void _movn(Variable *Dest, Variable *Src0, Variable *Src1) {
- Context.insert<InstMIPS32Movn>(Dest, Src0, Src1);
+ Context.insert<InstMIPS32Movn>(Dest, Src0, Src1)->setDestRedefined();
}
void _movn_d(Variable *Dest, Variable *Src0, Variable *Src1) {
- Context.insert<InstMIPS32Movn_d>(Dest, Src0, Src1);
- }
+ Context.insert<InstMIPS32Movn_d>(Dest, Src0, Src1)->setDestRedefined();
+}
Jim Stichnoth 2016/10/05 17:45:11 Indentation of this line is wrong. It is fixed au
void _movn_s(Variable *Dest, Variable *Src0, Variable *Src1) {
- Context.insert<InstMIPS32Movn_s>(Dest, Src0, Src1);
+ Context.insert<InstMIPS32Movn_s>(Dest, Src0, Src1)->setDestRedefined();
}
- void _movt(Variable *Src0, Variable *Src1, Operand *FCC) {
- auto *Instr = Context.insert<InstMIPS32Movt>(Src0, Src1, FCC);
- Instr->setDestRedefined();
+ void _movt(Variable *Dest, Variable *Src0, Operand *FCC) {
+ Context.insert<InstMIPS32Movt>(Dest, Src0, FCC)->setDestRedefined();
}
void _movz(Variable *Dest, Variable *Src0, Variable *Src1) {
- Context.insert<InstMIPS32Movz>(Dest, Src0, Src1);
+ Context.insert<InstMIPS32Movz>(Dest, Src0, Src1)->setDestRedefined();
}
void _movz_d(Variable *Dest, Variable *Src0, Variable *Src1) {
- Context.insert<InstMIPS32Movz_d>(Dest, Src0, Src1);
+ Context.insert<InstMIPS32Movz_d>(Dest, Src0, Src1)->setDestRedefined();
}
void _movz_s(Variable *Dest, Variable *Src0, Variable *Src1) {
- Context.insert<InstMIPS32Movz_s>(Dest, Src0, Src1);
+ Context.insert<InstMIPS32Movz_s>(Dest, Src0, Src1)->setDestRedefined();
}
void _mtc1(Variable *Dest, Variable *Src) {
« no previous file with comments | « src/IceInstMIPS32.cpp ('k') | tests_lit/assembler/mips32/encoding_intrinsics.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698