Subzero, MIPS32: Fix conditional mov instructions

src/IceTargetLoweringMIPS32.h

 //===- subzero/src/IceTargetLoweringMIPS32.h - MIPS32 lowering ---*- C++-*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 347 matching lines @@
   }
 
   void _mov_d(Variable *Dest, Variable *Src) {
     Context.insert<InstMIPS32Mov_d>(Dest, Src);
   }
 
   void _mov_s(Variable *Dest, Variable *Src) {
     Context.insert<InstMIPS32Mov_s>(Dest, Src);
   }
 
-  void _movf(Variable *Src0, Variable *Src1, Operand *FCC) {
-    auto *Instr = Context.insert<InstMIPS32Movf>(Src0, Src1, FCC);
-    Instr->setDestRedefined();
+  void _movf(Variable *Dest, Variable *Src0, Operand *FCC) {
+    Context.insert<InstMIPS32Movf>(Dest, Src0, FCC)->setDestRedefined();
   }
 
   void _movn(Variable *Dest, Variable *Src0, Variable *Src1) {
-    Context.insert<InstMIPS32Movn>(Dest, Src0, Src1);
+    Context.insert<InstMIPS32Movn>(Dest, Src0, Src1)->setDestRedefined();
   }
 
   void _movn_d(Variable *Dest, Variable *Src0, Variable *Src1) {
-    Context.insert<InstMIPS32Movn_d>(Dest, Src0, Src1);
+    Context.insert<InstMIPS32Movn_d>(Dest, Src0, Src1)->setDestRedefined();
+}

[Jim Stichnoth, 2016/10/05 17:45:11]

Indentation of this line is wrong.  It is fixed automatically by running
  make -f Makefile.standalone format
(I went ahead and fixed it.)

+
+  void _movn_s(Variable *Dest, Variable *Src0, Variable *Src1) {
+    Context.insert<InstMIPS32Movn_s>(Dest, Src0, Src1)->setDestRedefined();
   }
 
-  void _movn_s(Variable *Dest, Variable *Src0, Variable *Src1) {
-    Context.insert<InstMIPS32Movn_s>(Dest, Src0, Src1);
-  }
-
-  void _movt(Variable *Src0, Variable *Src1, Operand *FCC) {
-    auto *Instr = Context.insert<InstMIPS32Movt>(Src0, Src1, FCC);
-    Instr->setDestRedefined();
+  void _movt(Variable *Dest, Variable *Src0, Operand *FCC) {
+    Context.insert<InstMIPS32Movt>(Dest, Src0, FCC)->setDestRedefined();
   }
 
   void _movz(Variable *Dest, Variable *Src0, Variable *Src1) {
-    Context.insert<InstMIPS32Movz>(Dest, Src0, Src1);
+    Context.insert<InstMIPS32Movz>(Dest, Src0, Src1)->setDestRedefined();
   }
 
   void _movz_d(Variable *Dest, Variable *Src0, Variable *Src1) {
-    Context.insert<InstMIPS32Movz_d>(Dest, Src0, Src1);
+    Context.insert<InstMIPS32Movz_d>(Dest, Src0, Src1)->setDestRedefined();
   }
 
   void _movz_s(Variable *Dest, Variable *Src0, Variable *Src1) {
-    Context.insert<InstMIPS32Movz_s>(Dest, Src0, Src1);
+    Context.insert<InstMIPS32Movz_s>(Dest, Src0, Src1)->setDestRedefined();
   }
 
   void _mtc1(Variable *Dest, Variable *Src) {
     Context.insert<InstMIPS32Mtc1>(Dest, Src);
   }
 
   void _mthi(Variable *Dest, Operand *Src) {
     Context.insert<InstMIPS32Mthi>(Dest, Src);
   }
 
@@ skipping 460 matching lines @@
   explicit TargetHeaderMIPS32(GlobalContext *Ctx);
 
 private:
   ~TargetHeaderMIPS32() = default;
 };
 
 } // end of namespace MIPS32
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICETARGETLOWERINGMIPS32_H