Subzero, MIPS32: Fix conditional mov instructions

Subzero, MIPS32: Fix conditional mov instructions

This patch implements changes needed for conditional mov instructions
to fix problem with failing crosstest and invalid register allocation.
Problem is visible from icmp test examples, causing cross test for icmp
to fail. Eg:

Incorrect, before this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0043180a	movz	v1,v0,v0

Correct, aftrer this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0046180a	movz	v1,v0,a2

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=afe5fe227a89523c708b9543bbba1db90be36c82

[Stefan Maksimovic, 2016-10-05 16:27:21]

Description was changed from

==========
Subzero, MIPS32: Fix conditional mov instructions

This patch implements changes needed for conditional mov instructions
to fix problem with failing crosstest and invalid register allocation.
Problem is visible from icmp test examples, causing cross test for icmp
to fail. Eg:

Incorrect, before this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0043180a	movz	v1,v0,v0

Correct, aftrer this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0046180a	movz	v1,v0,a2
==========

to

==========
Subzero, MIPS32: Fix conditional mov instructions

This patch implements changes needed for conditional mov instructions
to fix problem with failing crosstest and invalid register allocation.
Problem is visible from icmp test examples, causing cross test for icmp
to fail. Eg:

Incorrect, before this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0043180a	movz	v1,v0,v0

Correct, aftrer this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0046180a	movz	v1,v0,a2
==========

[Stefan Maksimovic, 2016-10-05 16:27:21]

makdstefan@gmail.com changed reviewers:
+ eholk@chromium.org, jaydeep.patil@imgtec.com, jpp@chromium.org,
kschimpf@google.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-10-05 17:45:12]

lgtm

https://codereview.chromium.org/2394773004/diff/40001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.h (right):

https://codereview.chromium.org/2394773004/diff/40001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.h:378: }
Indentation of this line is wrong.  It is fixed automatically by running
  make -f Makefile.standalone format
(I went ahead and fixed it.)

[Jim Stichnoth, 2016-10-05 17:45:21]

Description was changed from

==========
Subzero, MIPS32: Fix conditional mov instructions

This patch implements changes needed for conditional mov instructions
to fix problem with failing crosstest and invalid register allocation.
Problem is visible from icmp test examples, causing cross test for icmp
to fail. Eg:

Incorrect, before this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0043180a	movz	v1,v0,v0

Correct, aftrer this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0046180a	movz	v1,v0,a2
==========

to

==========
Subzero, MIPS32: Fix conditional mov instructions

This patch implements changes needed for conditional mov instructions
to fix problem with failing crosstest and invalid register allocation.
Problem is visible from icmp test examples, causing cross test for icmp
to fail. Eg:

Incorrect, before this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0043180a	movz	v1,v0,v0

Correct, aftrer this change:
674:	00653026	xor	a2,v1,a1
678:	00a3182b	sltu	v1,a1,v1
67c:	0082102b	sltu	v0,a0,v0
680:	0046180a	movz	v1,v0,a2

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-10-05 17:45:22]

Committed patchset #3 (id:40001) manually as
afe5fe227a89523c708b9543bbba1db90be36c82 (presubmit successful).