| Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
|
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
|
| index 1b74a0b71b1717f3493df0860aaf54fd6543335f..cf50f15b07534c179a803f9f2c246e5e12e51aa3 100644
|
| --- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
|
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
|
| @@ -48,12 +48,6 @@ public class MinidumpUploadService extends IntentService {
|
| static final String LOCAL_CRASH_ID_KEY = "local_id";
|
|
|
| /**
|
| - * The number of times we will try to upload a crash.
|
| - */
|
| - @VisibleForTesting
|
| - static final int MAX_TRIES_ALLOWED = 3;
|
| -
|
| - /**
|
| * Histogram related constants.
|
| */
|
| private static final String HISTOGRAM_NAME_PREFIX = "Tab.AndroidCrashUpload_";
|
| @@ -222,7 +216,7 @@ public class MinidumpUploadService extends IntentService {
|
|
|
| // Since we do not rename a file after reaching max number of tries,
|
| // files that have maxed out tries will NOT reach this.
|
| - if (tries >= MAX_TRIES_ALLOWED || tries < 0) {
|
| + if (tries >= CrashFileManager.MAX_TRIES_ALLOWED || tries < 0) {
|
| // Reachable only if the file naming is incorrect by current standard.
|
| // Thus we log an error instead of recording failure to UMA.
|
| Log.e(TAG, "Giving up on trying to upload " + minidumpFileName
|
| @@ -249,7 +243,7 @@ public class MinidumpUploadService extends IntentService {
|
| // the file.
|
| String newName = CrashFileManager.tryIncrementAttemptNumber(minidumpFile);
|
| if (newName != null) {
|
| - if (++tries < MAX_TRIES_ALLOWED) {
|
| + if (++tries < CrashFileManager.MAX_TRIES_ALLOWED) {
|
| // TODO(nyquist): Do this as an exponential backoff.
|
| MinidumpUploadRetry.scheduleRetry(getApplicationContext());
|
| } else {
|
| @@ -334,7 +328,7 @@ public class MinidumpUploadService extends IntentService {
|
| */
|
| @VisibleForTesting
|
| MinidumpUploadCallable createMinidumpUploadCallable(File minidumpFile, File logfile) {
|
| - return new MinidumpUploadCallable(minidumpFile, logfile, getApplicationContext());
|
| + return new MinidumpUploadCallable(minidumpFile, logfile);
|
| }
|
|
|
| /**
|
|
|