chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java - Issue 2394763004: Componentize parts of minidump uploading for use from WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

Issue 2394763004: Componentize parts of minidump uploading for use from WebView. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java » ('j') | chrome/android/javatests/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

index acfd3a0947cddb2c955791caca5a11ea6f7b914f..80f6e1ff7b5eb2ca2e3770b9b1c8bad119a4167c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java

@@ -4,7 +4,6 @@

package org.chromium.chrome.browser.crash;

-import android.content.Context;

import android.content.SharedPreferences;

import android.support.annotation.IntDef;

@@ -14,8 +13,8 @@ import org.chromium.base.StreamUtil;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.browser.preferences.privacy.CrashReportingPermissionManager;

import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;

-import org.chromium.chrome.browser.util.HttpURLConnectionFactory;

-import org.chromium.chrome.browser.util.HttpURLConnectionFactoryImpl;

+import org.chromium.components.minidump_uploader.util.HttpURLConnectionFactory;

+import org.chromium.components.minidump_uploader.util.HttpURLConnectionFactoryImpl;

import java.io.BufferedReader;

import java.io.ByteArrayOutputStream;

@@ -71,7 +70,7 @@ public class MinidumpUploadCallable implements Callable<Integer> {

private final HttpURLConnectionFactory mHttpURLConnectionFactory;

private final CrashReportingPermissionManager mPermManager;

- public MinidumpUploadCallable(File fileToUpload, File logfile, Context context) {

+ public MinidumpUploadCallable(File fileToUpload, File logfile) {

this(fileToUpload, logfile, new HttpURLConnectionFactoryImpl(),

PrivacyPreferencesManager.getInstance());

removeOutdatedPrefs(ContextUtils.getAppSharedPreferences());