Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: tools/android/checkstyle/suppressions.xml

Issue 2394753002: Suppress the AlertDialog presubmit warning when not useful (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/checkstyle/suppressions.xml
diff --git a/tools/android/checkstyle/suppressions.xml b/tools/android/checkstyle/suppressions.xml
index 57ba3cede9b9a7da6ed6e6413e9f2a09e457c375..9ae1852ec53226a43a00429b1f1529f14c959184 100644
--- a/tools/android/checkstyle/suppressions.xml
+++ b/tools/android/checkstyle/suppressions.xml
@@ -3,6 +3,5 @@
<suppressions>
<suppress id="SharedPreferencesCheck" files="ContextUtils.java"/>
- <!-- TODO(crbug.com/635567): Fix this properly. -->
- <suppress id="AlertDialogCheck" files="MultiFieldTimePickerDialog.java"/>
+ <suppress id="AlertDialogCheck" files="src/content/"/>
Ted C 2016/10/05 16:10:12 really, we want to suppress this for every directo
wychen 2016/10/06 23:12:28 What about blimp/ and remoting/? They already have
</suppressions>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698