tools/android/checkstyle/suppressions.xml - Issue 2394753002: Suppress the AlertDialog presubmit warning when not useful

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/android/checkstyle/suppressions.xml

Issue 2394753002: Suppress the AlertDialog presubmit warning when not useful (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http:/ /www.puppycrawl.com/dtds/suppressions_1_1.dtd">	2 <!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http:/ /www.puppycrawl.com/dtds/suppressions_1_1.dtd">

3	3

4 <suppressions>	4 <suppressions>

5 <suppress id="SharedPreferencesCheck" files="ContextUtils.java"/>	5 <suppress id="SharedPreferencesCheck" files="ContextUtils.java"/>

6 <!-- TODO(crbug.com/635567): Fix this properly. -->	6 <suppress id="AlertDialogCheck" files="src/content/"/>
	Ted C 2016/10/05 16:10:12 really, we want to suppress this for every directo really, we want to suppress this for every directory but chrome...don't know if that is possible though. wychen 2016/10/06 23:12:28 What about blimp/ and remoting/? They already have Show quoted text On 2016/10/05 16:10:12, Ted C wrote: > really, we want to suppress this for every directory but chrome...don't know if > that is possible though. What about blimp/ and remoting/? They already have android.support.v7.app.AlertDialog usage. I think it makes sense to add these to our whitelist as well. This suppression list only works by using a regex to match file names, so the best we can do here is to enumerate all the directory names under src/ except for the whitelisted ones. It's not ideal, but since it's pretty rare to add top-level directories under src/, we don't have to worry about updating this often.
7 <suppress id="AlertDialogCheck" files="MultiFieldTimePickerDialog.java"/>

8 </suppressions>	7 </suppressions>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »