[Mac Fix-It] removed base::mac::AmIForeground function.

[Mac Fix-It] removed base::mac::AmIForeground function.

Use [[NSRunningApplication currentApplication] isActive]
call instead.

BUG=650854
Committed: https://crrev.com/1cc274c36c784591ed4a0fcd6dab7465e033c823
Cr-Commit-Position: refs/heads/master@{#423425}

[Eugene But (OOO till 7-30), 2016-10-05 02:23:15]

eugenebut@chromium.org changed reviewers:
+ thakis@chromium.org

[Eugene But (OOO till 7-30), 2016-10-05 02:23:15]

base::mac::AmIForeground() is actually used only in once place.
Should I just remove base::mac::AmIForeground() and directly use
|[[NSApplication sharedApplication] isActive]|? 

mac_util.h file looks like a dump of various unrelated things.

[Nico, 2016-10-05 14:19:39]

Thanks for the patch!

https://codereview.chromium.org/2394733002/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

https://codereview.chromium.org/2394733002/diff/1/base/mac/mac_util.mm#newcod...
base/mac/mac_util.mm:222: return [[NSApplication sharedApplication] isActive];
Is [[NSRunningApplication currentApplication] isActive] maybe better?
[NSApplication sharedApplication] will do things like init Cocoa etc if that
hasn't been done yet, and this is a function in base.

Hm, actually, now that the implementation of this is one line and given that
this has only a single caller, maybe we could just remove this function in base
and then do what it does at the one caller's place directly (and since that's in
chrome, your method is fine there too). WDYT?

[Eugene But (OOO till 7-30), 2016-10-06 00:30:05]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 00:30:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-10-06 00:31:00]

Description was changed from

==========
[Mac Fix-It] Use NSApplication for AmIForeground implementation.

GetFrontProcess and SameProcess are deprecated.

BUG=650854
==========

to

==========
[Mac Fix-It] removed base::mac::AmIForeground function.

Use [[NSRunningApplication currentApplication] isActive]
call instead.

BUG=650854
==========

[Eugene But (OOO till 7-30), 2016-10-06 00:32:00]

PTAL

https://codereview.chromium.org/2394733002/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

https://codereview.chromium.org/2394733002/diff/1/base/mac/mac_util.mm#newcod...
base/mac/mac_util.mm:222: return [[NSApplication sharedApplication] isActive];
On 2016/10/05 14:19:39, Nico wrote:
> Is [[NSRunningApplication currentApplication] isActive] maybe better?
> [NSApplication sharedApplication] will do things like init Cocoa etc if that
> hasn't been done yet, and this is a function in base.
> 
> Hm, actually, now that the implementation of this is one line and given that
> this has only a single caller, maybe we could just remove this function in
base
> and then do what it does at the one caller's place directly (and since that's
in
> chrome, your method is fine there too). WDYT?
Yeah, that what I asked in the comments (should we just drop AmIForeground) :)
Changed to use [NSRunningApplication currentApplication] and dropped
AmIForeground.

[commit-bot: I haz the power, 2016-10-06 01:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 01:09:06]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-10-06 01:44:32]

Lgtm

Since we now know that NSApp is already initialized, [NSApp isActive] would work
too and is a bit shorter (but up to you)

[Eugene But (OOO till 7-30), 2016-10-06 03:57:37]

On 2016/10/06 01:44:32, Nico wrote:
> Lgtm
> 
> Since we now know that NSApp is already initialized, [NSApp isActive] would
work
> too and is a bit shorter (but up to you)
[[NSApp sharedApplication] isActive] crashes:

2016-10-06 14:56:10.828 Chromium[36197:6175156] -[BrowserCrApplication
sharedApplication]: unrecognized selector sent to instance 0x6200001200a0

landing as it is. Thanks for quick reviews.

[Eugene But (OOO till 7-30), 2016-10-06 03:57:44]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-10-06 03:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 04:02:50]

Description was changed from

==========
[Mac Fix-It] removed base::mac::AmIForeground function.

Use [[NSRunningApplication currentApplication] isActive]
call instead.

BUG=650854
==========

to

==========
[Mac Fix-It] removed base::mac::AmIForeground function.

Use [[NSRunningApplication currentApplication] isActive]
call instead.

BUG=650854
==========

[commit-bot: I haz the power, 2016-10-06 04:02:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 04:04:14]

Description was changed from

==========
[Mac Fix-It] removed base::mac::AmIForeground function.

Use [[NSRunningApplication currentApplication] isActive]
call instead.

BUG=650854
==========

to

==========
[Mac Fix-It] removed base::mac::AmIForeground function.

Use [[NSRunningApplication currentApplication] isActive]
call instead.

BUG=650854

Committed: https://crrev.com/1cc274c36c784591ed4a0fcd6dab7465e033c823
Cr-Commit-Position: refs/heads/master@{#423425}
==========

[commit-bot: I haz the power, 2016-10-06 04:04:15]

Patchset 2 (id:??) landed as
https://crrev.com/1cc274c36c784591ed4a0fcd6dab7465e033c823
Cr-Commit-Position: refs/heads/master@{#423425}

[Nico, 2016-10-06 04:17:07]

Either [NSApp active] or [[NSApplication sharedInstance] active]. NSApp is
a global of type NSApplication*, not a class.

On Oct 5, 2016 11:57 PM, "commit-bot@chromium.org via
codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

> CQ is trying da patch. Follow status at
>
> https://chromium-cq-status.appspot.com/v2/patch-status/
> codereview.chromium.org/2394733002/20001
>
>
> https://codereview.chromium.org/2394733002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Eugene But (OOO till 7-30), 2016-10-06 04:28:21]

On 2016/10/06 04:17:07, Nico wrote:
> Either [NSApp active] or [[NSApplication sharedInstance] active]. NSApp is
> a global of type NSApplication*, not a class.
> 
> On Oct 5, 2016 11:57 PM, mailto:"commit-bot@chromium.org via
> codereview.chromium.org" <mailto:reply@chromiumcodereview-hr.appspotmail.com>
> wrote:
> 
> > CQ is trying da patch. Follow status at
> >
> > https://chromium-cq-status.appspot.com/v2/patch-status/
> > codereview.chromium.org/2394733002/20001
> >
> >
> > https://codereview.chromium.org/2394733002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
Oh, good to know. Sorry this has landed already :(