[Mac Fix-It] removed base::mac::AmIForeground function.

base/mac/mac_util.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac/mac_util.h"
 
 #import <Cocoa/Cocoa.h>
 #import <IOKit/IOKitLib.h>
 #include <errno.h>
 #include <stddef.h>
@@ skipping 201 matching lines @@
   DCHECK_GT(g_full_screen_requests[from_mode], 0);
   DCHECK_GE(g_full_screen_requests[to_mode], 0);
   g_full_screen_requests[from_mode] =
       std::max(g_full_screen_requests[from_mode] - 1, 0);
   g_full_screen_requests[to_mode] =
       std::max(g_full_screen_requests[to_mode] + 1, 1);
   SetUIMode();
 }
 
 bool AmIForeground() {
-  ProcessSerialNumber foreground_psn = { 0 };
-  OSErr err = GetFrontProcess(&foreground_psn);
-  if (err != noErr) {
-    OSSTATUS_DLOG(WARNING, err) << "GetFrontProcess";
-    return false;
-  }
-
-  ProcessSerialNumber my_psn = { 0, kCurrentProcess };
-
-  Boolean result = FALSE;
-  err = SameProcess(&foreground_psn, &my_psn, &result);
-  if (err != noErr) {
-    OSSTATUS_DLOG(WARNING, err) << "SameProcess";
-    return false;
-  }
-
-  return result;
+  return [[NSApplication sharedApplication] isActive];

[Nico, 2016/10/05 14:19:39]

Is [[NSRunningApplication currentApplication] isActive] maybe better?
[NSApplication sharedApplication] will do things like init Cocoa etc if that
hasn't been done yet, and this is a function in base.

Hm, actually, now that the implementation of this is one line and given that
this has only a single caller, maybe we could just remove this function in base
and then do what it does at the one caller's place directly (and since that's in
chrome, your method is fine there too). WDYT?

[Eugene But (OOO till 7-30), 2016/10/06 00:31:59]

Yeah, that what I asked in the comments (should we just drop AmIForeground) :)
Changed to use [NSRunningApplication currentApplication] and dropped
AmIForeground.

 }
 
 bool SetFileBackupExclusion(const FilePath& file_path) {
   NSString* file_path_ns =
       [NSString stringWithUTF8String:file_path.value().c_str()];
   NSURL* file_url = [NSURL fileURLWithPath:file_path_ns];
 
   // When excludeByPath is true the application must be running with root
   // privileges (admin for 10.6 and earlier) but the URL does not have to
   // already exist. When excludeByPath is false the URL must already exist but
@@ skipping 246 matching lines @@
           StringPiece(begin + comma_loc + 1, ident.end()), &minor_tmp))
     return false;
   *type = ident.substr(0, number_loc);
   *major = major_tmp;
   *minor = minor_tmp;
   return true;
 }
 
 }  // namespace mac
 }  // namespace base