Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2394583002: Move shouldApplyAnimation to SVGAnimateElement (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move shouldApplyAnimation to SVGAnimateElement Only used by SVGAnimateElement. BUG=641437 Committed: https://crrev.com/5030e7f661b95940dc80c6f101fedbbd9b77cbfc Cr-Commit-Position: refs/heads/master@{#422935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 2 months ago (2016-10-04 20:57:17 UTC) #6
pdr.
On 2016/10/04 at 20:57:17, fs wrote: > LGTM
4 years, 2 months ago (2016-10-04 21:13:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394583002/1
4 years, 2 months ago (2016-10-04 21:15:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 21:30:20 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:33:38 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5030e7f661b95940dc80c6f101fedbbd9b77cbfc
Cr-Commit-Position: refs/heads/master@{#422935}

Powered by Google App Engine
This is Rietveld 408576698