Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

Issue 2394583002: Move shouldApplyAnimation to SVGAnimateElement (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimationElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
index 089185dbd7dcdb72a9f054c1b1cd01a3468c19ae..b080c1423156364ce9c49136e32adb8a44bf4248 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
@@ -357,30 +357,6 @@ bool SVGAnimationElement::isTargetAttributeCSSProperty(
targetElement->isPresentationAttribute(attributeName);
}
-SVGAnimationElement::ShouldApplyAnimationType
-SVGAnimationElement::shouldApplyAnimation(SVGElement* targetElement,
- const QualifiedName& attributeName) {
- if (!hasValidAttributeType() || attributeName == anyQName() ||
- !targetElement || !targetElement->inActiveDocument() ||
- !targetElement->parentNode())
- return DontApplyAnimation;
-
- // Always animate CSS properties using the ApplyCSSAnimation code path,
- // regardless of the attributeType value.
- if (isTargetAttributeCSSProperty(targetElement, attributeName)) {
- if (targetElement->isPresentationAttributeWithSVGDOM(attributeName))
- return ApplyXMLandCSSAnimation;
-
- return ApplyCSSAnimation;
- }
- // If attributeType="CSS" and attributeName doesn't point to a CSS property,
- // ignore the animation.
- if (getAttributeType() == AttributeTypeCSS)
- return DontApplyAnimation;
-
- return ApplyXMLAnimation;
-}
-
void SVGAnimationElement::calculateKeyTimesForCalcModePaced() {
ASSERT(getCalcMode() == CalcModePaced);
ASSERT(getAnimationMode() == ValuesAnimation);
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimationElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698