Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2394523002: cocoa browser: remove non-MD bookmark bar support (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa browser: remove non-MD bookmark bar support This change removes all uses of IsModeMaterial() in c/b/ui/c/bookmarks and refactors the code a bunch as a result. BUG=649368 Committed: https://crrev.com/d962357fabdddef622539968dc4b6344085fbeec Cr-Commit-Position: refs/heads/master@{#422867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -385 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 30 chunks +75 lines, -166 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 5 chunks +14 lines, -39 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 10 chunks +20 lines, -47 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 5 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm View 2 chunks +2 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 7 chunks +38 lines, -69 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
avi: ptal? :)
4 years, 2 months ago (2016-10-04 15:28:57 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-04 15:31:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394523002/1
4 years, 2 months ago (2016-10-04 18:07:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 18:40:48 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:44:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d962357fabdddef622539968dc4b6344085fbeec
Cr-Commit-Position: refs/heads/master@{#422867}

Powered by Google App Engine
This is Rietveld 408576698