chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm - Issue 2394523002: cocoa browser: remove non-MD bookmark bar support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

Issue 2394523002: cocoa browser: remove non-MD bookmark bar support (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

index ea9e7f7f4bbfcf374f7de35fc7ce217d8a06ded9..2bd05cba6842eb1e434b304278d71bcf9b940eee 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm

@@ -130,12 +130,9 @@ bool IsWindowClosing() {

NSWindow* window = [controller window];

EXPECT_TRUE(window);

NSRect browser_window_frame = [browser()->window()->GetNativeWindow() frame];

- // The metrics have changed slightly under Material Design, so that in this

- // test case the bookmarks bubble's window frame extendeds slightly beyond its

- // parent window's frame.

- if (ui::MaterialDesignController::IsModeMaterial()) {

- browser_window_frame.size.width += 1;

- }

+ // In this test case the bookmarks bubble's window frame extendeds slightly

+ // beyond its parent window's frame.

+ browser_window_frame.size.width += 1;

EXPECT_TRUE(NSContainsRect(browser_window_frame, [window frame]));

}