Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake.

Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake.

BUG=650925
TBR=sadrul

Committed: https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a
Cr-Commit-Position: refs/heads/master@{#423635}

[gab, 2016-10-06 18:59:53]

Patchset #1 (id:1) has been deleted

[gab, 2016-10-06 19:01:30]

gab@chromium.org changed reviewers:
+ sadrul@chromium.org

[gab, 2016-10-06 19:01:31]

Sadrul PTAL, this is to help diagnose a recurring flake.

[gab, 2016-10-06 19:01:45]

Description was changed from

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
==========

to

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
==========

[gab, 2016-10-06 19:02:29]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 19:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:24:27]

Dry run: This issue passed the CQ dry run.

[gab, 2016-10-06 19:33:36]

Description was changed from

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
==========

to

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
TBR=sadrul
==========

[gab, 2016-10-06 19:34:17]

On 2016/10/06 19:01:31, gab wrote:
> Sadrul PTAL, this is to help diagnose a recurring flake.

TBR to hopefully catch the next flake. Feel free to revert or ask for follow-up
if anything.

[gab, 2016-10-06 19:34:21]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:43:02]

Description was changed from

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
TBR=sadrul
==========

to

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
TBR=sadrul
==========

[commit-bot: I haz the power, 2016-10-06 19:43:05]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-06 19:46:37]

Description was changed from

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
TBR=sadrul
==========

to

==========
Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf
flake.

BUG=650925
TBR=sadrul

Committed: https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a
Cr-Commit-Position: refs/heads/master@{#423635}
==========

[commit-bot: I haz the power, 2016-10-06 19:46:38]

Patchset 1 (id:??) landed as
https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a
Cr-Commit-Position: refs/heads/master@{#423635}

[sadrul, 2016-10-06 20:03:10]

On 2016/10/06 19:46:38, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a
> Cr-Commit-Position: refs/heads/master@{#423635}

I think https://codereview.chromium.org/2391823004/ is expected to fix the
flakiness.

[gab, 2016-10-06 20:28:30]

On 2016/10/06 20:03:10, sadrul wrote:
> On 2016/10/06 19:46:38, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a
> > Cr-Commit-Position: refs/heads/master@{#423635}
> 
> I think https://codereview.chromium.org/2391823004/ is expected to fix the
> flakiness.

I see, still weird that a unit test isn't deterministic though, i.e. sure
floating point arithmetic isn't precise but it should be deterministic?

Feel free to revert this.

[gab, 2016-10-07 17:24:22]

On 2016/10/06 20:28:30, gab wrote:
> On 2016/10/06 20:03:10, sadrul wrote:
> > On 2016/10/06 19:46:38, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/d7cbf7ccc5f21177c925657fd50c688ca437526a
> > > Cr-Commit-Position: refs/heads/master@{#423635}
> > 
> > I think https://codereview.chromium.org/2391823004/ is expected to fix the
> > flakiness.
> 
> I see, still weird that a unit test isn't deterministic though, i.e. sure
> floating point arithmetic isn't precise but it should be deterministic?
> 
> Feel free to revert this.

From the logs it looks like the result arrives at 423.5 -- I guess that's
somehow undeterministically rounded up/down depending on the precision of float
arithmetic?! Maybe even depends on a given bot's CPU architecture? e.g. whether
it's holding 423.50000000000000001 or 423.4999999999999 before rounding..?

error: Value of: round(precise_toast_bounds.CenterPoint().x())
  Actual: 423
Expected: round(shelf_bounds.right() + (root_bounds.width() -
shelf_bounds.width()) / 2.0)
Which is: 424
Shelf right bound: 47
Root width: 800
Shelf width: 47
Precise toast center x position: 423

[gab, 2016-10-07 19:14:11]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2402763002/ by gab@chromium.org.

The reason for reverting is: https://codereview.chromium.org/2391823004/ will
fix http://crbug.com/650925 and can't land as-is (patch failure) because of this
CL.