Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: ash/system/toast/toast_manager_unittest.cc

Issue 2394483006: Log extra information on weird ToastManagerTest.PositionWithVisibleLeftShelf flake. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/toast/toast_manager_unittest.cc
diff --git a/ash/system/toast/toast_manager_unittest.cc b/ash/system/toast/toast_manager_unittest.cc
index 04d5355a6c373dbe5905adeefb4c91cacdfbd57b..f7e89f4b1811a2ad924f8aeca35671bdceaeb52f 100644
--- a/ash/system/toast/toast_manager_unittest.cc
+++ b/ash/system/toast/toast_manager_unittest.cc
@@ -235,7 +235,12 @@ TEST_F(ToastManagerTest, PositionWithVisibleLeftShelf) {
EXPECT_FALSE(toast_bounds.Intersects(shelf_bounds));
EXPECT_EQ(round(shelf_bounds.right() +
(root_bounds.width() - shelf_bounds.width()) / 2.0),
- round(precise_toast_bounds.CenterPoint().x()));
+ round(precise_toast_bounds.CenterPoint().x()))
+ << "Shelf right bound: " << shelf_bounds.right()
+ << "\nRoot width: " << root_bounds.width()
+ << "\nShelf width: " << shelf_bounds.width()
+ << "\nPrecise toast center x position: "
+ << precise_toast_bounds.CenterPoint().x();
}
TEST_F(ToastManagerTest, PositionWithUnifiedDesktop) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698