Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 2394473005: Move enum BluetoothDevice::DeviceType out of BluetoothDevice class. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, ortuno+watch_chromium.org, oshima+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move enum BluetoothDevice::DeviceType out of BluetoothDevice class. This CL moves the inner enum BluetoothDevice::DeviceType out of BluetoothDevice class so that we can refer it using forward declaration. We are going to use it in ash/common/system/tray/system_tray_delegate.h https://codereview.chromium.org/2381493005/. BUG=632128 TEST=none TBR=stevenjb@chromium.org Committed: https://crrev.com/6da34d65da4b98f6cc5957e08a682470e056eea6 Cr-Commit-Position: refs/heads/master@{#423328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -121 lines) Patch
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 5 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M components/proximity_auth/bluetooth_connection_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_common.h View 1 chunk +20 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 2 chunks +1 line, -21 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 7 chunks +38 lines, -38 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 9 chunks +11 lines, -10 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api_utils.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
fukino
Hi ortuno@, stevenjb@, achuith@, isherman@, I moved the inner enum BluetoothDevice::DeviceType out of BluetoothDevice class, ...
4 years, 2 months ago (2016-10-05 07:31:47 UTC) #4
ortuno
lgtm
4 years, 2 months ago (2016-10-05 07:34:15 UTC) #7
achuithb
c/b/cros/login/* lgtm
4 years, 2 months ago (2016-10-05 21:31:16 UTC) #10
Ilya Sherman
metrics and proximity_auth changes lgtm, and this seems like the sort of change that would ...
4 years, 2 months ago (2016-10-05 22:46:27 UTC) #11
fukino
Thanks! TBRing stevenjb@ for mechanical changes in extensions/browser/api/bluetooth/*
4 years, 2 months ago (2016-10-05 22:56:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394473005/1
4 years, 2 months ago (2016-10-05 22:57:30 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 23:03:33 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:06:07 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6da34d65da4b98f6cc5957e08a682470e056eea6
Cr-Commit-Position: refs/heads/master@{#423328}

Powered by Google App Engine
This is Rietveld 408576698