Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java

Issue 2394373002: Refactor ChromeActivity references out of TabModelSelectorImpl (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
index c848ff843ecf452c5ad4375ceb99cee68c47d4a5..8cc1d9223e0ed431951488f748e60b7e6b9a57bb 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.tabmodel;
+import android.app.Activity;
import android.content.SharedPreferences;
import android.os.AsyncTask;
import android.test.suitebuilder.annotation.SmallTest;
@@ -19,6 +20,8 @@ import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.TabState;
import org.chromium.chrome.browser.compositor.overlays.strip.StripLayoutHelper;
+import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
+import org.chromium.chrome.browser.fullscreen.FullscreenManager;
import org.chromium.chrome.browser.snackbar.undo.UndoBarController;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator;
@@ -253,12 +256,19 @@ public class TabPersistentStoreTest extends NativeLibraryTestBase {
protected boolean handleBackPressed() {
return false;
}
+
+ @Override
+ protected ChromeFullscreenManager createFullscreenManager() {
+ return null;
+ }
};
private final TabWindowManager.TabModelSelectorFactory mMockTabModelSelectorFactory =
new TabWindowManager.TabModelSelectorFactory() {
@Override
- public TabModelSelector buildSelector(ChromeActivity activity, int selectorIndex) {
+ public TabModelSelector buildSelector(Activity activity,
+ TabCreatorManager tabCreatorManager, FullscreenManager fullscreenManager,
+ int selectorIndex) {
try {
return new TestTabModelSelector();
} catch (Exception e) {
@@ -654,7 +664,7 @@ public class TabPersistentStoreTest extends NativeLibraryTestBase {
tabWindowManager.onActivityStateChange(
mFakeChromeActivity, ActivityState.DESTROYED);
return (TestTabModelSelector) tabWindowManager.requestSelector(
- mFakeChromeActivity, 0);
+ mFakeChromeActivity, mFakeChromeActivity, null, 0);
}
});

Powered by Google App Engine
This is Rietveld 408576698