Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3188)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java

Issue 2394373002: Refactor ChromeActivity references out of TabModelSelectorImpl (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
index 1403419ac46d3c5ad21ed263b75d531d4cf1049a..e2562577a0cfa55e703ae20e212e894298e862dc 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.tabmodel;
+import android.app.Activity;
import android.os.Environment;
import android.test.suitebuilder.annotation.MediumTest;
@@ -11,7 +12,7 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.fullscreen.FullscreenManager;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabWindowManager.TabModelSelectorFactory;
@@ -47,8 +48,10 @@ public class ContextMenuLoadUrlParamsTest extends ChromeTabbedActivityTestBase {
return super.openNewTab(loadUrlParams, type, parent, incognito);
}
- public RecordingTabModelSelector(ChromeActivity activity, int selectorIndex) {
- super(activity, new TabbedModeTabPersistencePolicy(selectorIndex, false), true);
+ public RecordingTabModelSelector(Activity activity, TabCreatorManager tabCreatorManager,
+ FullscreenManager fullscreenManager, int selectorIndex) {
+ super(activity, tabCreatorManager, fullscreenManager,
+ new TabbedModeTabPersistencePolicy(selectorIndex, false), true);
}
}
@@ -63,9 +66,11 @@ public class ContextMenuLoadUrlParamsTest extends ChromeTabbedActivityTestBase {
TabWindowManager.getInstance().setTabModelSelectorFactory(
new TabModelSelectorFactory() {
@Override
- public TabModelSelector buildSelector(ChromeActivity activity,
- int selectorIndex) {
- return new RecordingTabModelSelector(activity, selectorIndex);
+ public TabModelSelector buildSelector(
+ Activity activity, TabCreatorManager tabCreatorManager,
+ FullscreenManager fullscreenManager, int selectorIndex) {
+ return new RecordingTabModelSelector(activity, tabCreatorManager,
+ fullscreenManager, selectorIndex);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698