Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2394323002: GN: Initialize Tool::defined_from_ in the constructor (Closed)

Created:
4 years, 2 months ago by timn
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Initialize Tool::defined_from_ in the constructor set_defined_from() isn't called in some tests (e.g. those using TestWithScope), thus calling defined_from() will only yield garbage, likely leading to a crash. BUG= Committed: https://crrev.com/fb7800730f213aba891c83df31b7183fc4cbcdc5 Cr-Commit-Position: refs/heads/master@{#423698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/tool.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
timn
4 years, 2 months ago (2016-10-06 21:16:54 UTC) #2
brettw
awesome, thanks. LGTM
4 years, 2 months ago (2016-10-06 21:26:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394323002/1
4 years, 2 months ago (2016-10-06 21:29:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 21:46:07 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:47:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7800730f213aba891c83df31b7183fc4cbcdc5
Cr-Commit-Position: refs/heads/master@{#423698}

Powered by Google App Engine
This is Rietveld 408576698