Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: tools/gn/tool.cc

Issue 2394323002: GN: Initialize Tool::defined_from_ in the constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/tool.h" 5 #include "tools/gn/tool.h"
6 6
7 Tool::Tool() 7 Tool::Tool()
8 : depsformat_(DEPS_GCC), 8 : defined_from_(nullptr),
9 depsformat_(DEPS_GCC),
9 precompiled_header_type_(PCH_NONE), 10 precompiled_header_type_(PCH_NONE),
10 restat_(false), 11 restat_(false),
11 complete_(false) { 12 complete_(false) {
12 } 13 }
13 14
14 Tool::~Tool() { 15 Tool::~Tool() {
15 } 16 }
16 17
17 void Tool::SetComplete() { 18 void Tool::SetComplete() {
18 DCHECK(!complete_); 19 DCHECK(!complete_);
19 complete_ = true; 20 complete_ = true;
20 21
21 command_.FillRequiredTypes(&substitution_bits_); 22 command_.FillRequiredTypes(&substitution_bits_);
22 depfile_.FillRequiredTypes(&substitution_bits_); 23 depfile_.FillRequiredTypes(&substitution_bits_);
23 description_.FillRequiredTypes(&substitution_bits_); 24 description_.FillRequiredTypes(&substitution_bits_);
24 outputs_.FillRequiredTypes(&substitution_bits_); 25 outputs_.FillRequiredTypes(&substitution_bits_);
25 link_output_.FillRequiredTypes(&substitution_bits_); 26 link_output_.FillRequiredTypes(&substitution_bits_);
26 depend_output_.FillRequiredTypes(&substitution_bits_); 27 depend_output_.FillRequiredTypes(&substitution_bits_);
27 rspfile_.FillRequiredTypes(&substitution_bits_); 28 rspfile_.FillRequiredTypes(&substitution_bits_);
28 rspfile_content_.FillRequiredTypes(&substitution_bits_); 29 rspfile_content_.FillRequiredTypes(&substitution_bits_);
29 } 30 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698