Fix the snapshot_cache unittests.

Fix the snapshot_cache unittests.

This fix is necessary to enable by default the iPad tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS.
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None

Committed: https://crrev.com/8eb38982d179e056b228269832582c1f2c998a3a
Cr-Commit-Position: refs/heads/master@{#427302}

[jif, 2016-10-06 17:54:45]

Description was changed from

==========
Enable Tab Switcher by default.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

BUG=None
==========

[jif, 2016-10-06 17:54:46]

jif@chromium.org changed reviewers:
+ sdefresne@chromium.org

[jif, 2016-10-06 17:54:57]

ptal (but don't commit)

[sdefresne, 2016-10-06 20:26:45]

lgtm

[sdefresne, 2016-10-06 20:26:50]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:38:54]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jif-google, 2016-10-07 14:18:53]

Description was changed from

==========
Enable Tab Switcher by default.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

Reland of https://codereview.chromium.org/1725533004

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[jif-google, 2016-10-07 14:20:00]

Patchset #2 (id:20001) has been deleted

[jif, 2016-10-07 14:20:17]

The CQ bit was checked by jif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 14:20:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jif, 2016-10-07 14:41:08]

On 2016/10/06 20:26:45, sdefresne wrote:
> lgtm

ptal again.
please note that the patch is now an reland of
https://codereview.chromium.org/1725533004 (minus the gyp change).

[sdefresne, 2016-10-07 14:56:19]

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
File ios/chrome/browser/snapshots/snapshot_cache.mm (right):

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache.mm:567: if ([self usesLRUCache])
The test changed, is this expected?

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right):

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:199: //
_performMemoryWarning is a private API and musn't be compiled into
nit: musn't -> must not

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:221: if ([cache
usesLRUCache])
This test changed too, is this expected?

[commit-bot: I haz the power, 2016-10-07 15:08:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:08:23]

Dry run: This issue passed the CQ dry run.

[jif, 2016-10-24 14:57:51]

Description was changed from

==========
Enable Tab Switcher by default.

Reland of https://codereview.chromium.org/1725533004

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[jif, 2016-10-24 15:10:03]

ptal.
I've reduced the scope of this CL: it now simply fixes the snapshot_cache
unittests.

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
File ios/chrome/browser/snapshots/snapshot_cache.mm (right):

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache.mm:567: if ([self usesLRUCache])
On 2016/10/07 14:56:19, sdefresne wrote:
> The test changed, is this expected?

Yes. It is now correct:
The LRU cache is used when IsLRUSnapshotCacheEnabled OR when the tab switcher is
enabled.

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right):

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:199: //
_performMemoryWarning is a private API and musn't be compiled into
On 2016/10/07 14:56:19, sdefresne wrote:
> nit: musn't -> must not

Done.

https://codereview.chromium.org/2394253002/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:221: if ([cache
usesLRUCache])
On 2016/10/07 14:56:19, sdefresne wrote:
> This test changed too, is this expected?

Yes: same reason as in the other test.

[jif, 2016-10-24 16:32:28]

Description was changed from

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the iPad tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS.
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[sdefresne, 2016-10-24 16:58:43]

lgtm

[jif-google, 2016-10-24 16:59:13]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2016-10-24 16:59:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 17:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:02:46]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jif, 2016-10-24 17:27:05]

The CQ bit was checked by jif@chromium.org

[jif, 2016-10-24 17:27:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2394253002/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-10-24 17:27:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 17:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:51:14]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jif, 2016-10-24 19:11:42]

The CQ bit was checked by jif@chromium.org

[jif, 2016-10-24 19:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2394253002/#ps100001
(title: "Fixed test.")

[commit-bot: I haz the power, 2016-10-24 19:12:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 23:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:39:15]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[jif-google, 2016-10-25 08:27:26]

The CQ bit was checked by jif@google.com

[commit-bot: I haz the power, 2016-10-25 08:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 09:41:20]

Description was changed from

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the iPad tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS.
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the iPad tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS.
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[commit-bot: I haz the power, 2016-10-25 09:41:21]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-10-25 09:43:30]

Description was changed from

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the iPad tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS.
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Fix the snapshot_cache unittests.

This fix is necessary to enable by default the iPad tab switcher.
It is a partial reland of https://codereview.chromium.org/1725533004

This CL:
-Always register/deregister for notifications.
-Centralizes the logic to use a LRU cache.
-Centralizes the logic to use an in-memory cache.
-Replaces msarda with jif in OWNERS.
-Triggers memory warning instead of calling |handleLowMemory| from tests.

BUG=None

Committed: https://crrev.com/8eb38982d179e056b228269832582c1f2c998a3a
Cr-Commit-Position: refs/heads/master@{#427302}
==========

[commit-bot: I haz the power, 2016-10-25 09:43:31]

Patchset 5 (id:??) landed as
https://crrev.com/8eb38982d179e056b228269832582c1f2c998a3a
Cr-Commit-Position: refs/heads/master@{#427302}