Enable iPad Tab Switcher by default on iOS.

Enable iPad Tab Switcher by default on iOS.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None

Committed: https://crrev.com/7bc8524f4e0b9fa3a7758a81f195a0228196b8d4
Cr-Commit-Position: refs/heads/master@{#377570}

[jif, 2016-02-23 16:47:48]

Description was changed from

==========
Enable Tab Switcher by default.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

BUG=None
==========

[jif, 2016-02-23 16:47:48]

jif@chromium.org changed reviewers:
+ sdefresne@chromium.org

[jif, 2016-02-23 16:48:16]

ptal

[sdefresne, 2016-02-23 16:50:26]

lgtm

[jif, 2016-02-23 16:50:34]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725533004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725533004/1

[commit-bot: I haz the power, 2016-02-23 17:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 17:15:36]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jif, 2016-02-25 09:55:28]

Description was changed from

==========
Enable Tab Switcher by default.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

In order to do that, the snapshot_cache unittests needed to be fixed.
In order to do that, the snapshot_cache needed to be cleaned up.

BUG=None
==========

[jif, 2016-02-25 09:55:51]

Description was changed from

==========
Enable Tab Switcher by default.

In order to do that, the snapshot_cache unittests needed to be fixed.
In order to do that, the snapshot_cache needed to be cleaned up.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up.

BUG=None
==========

[jif, 2016-02-25 09:57:43]

Description was changed from

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up/fixed.

BUG=None
==========

[jif, 2016-02-25 09:59:20]

Description was changed from

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up/fixed.

BUG=None
==========

to

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.

BUG=455209
==========

[jif, 2016-02-25 10:00:14]

Description was changed from

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.
-Centralize the decision to use a LRU cache and to use an in-memory cache.

BUG=455209
==========

[jif, 2016-02-25 10:00:22]

Description was changed from

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.
-Centralize the decision to use a LRU cache and to use an in-memory cache.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache and to use an in-memory cache.

BUG=455209
==========

[jif, 2016-02-25 10:00:39]

Description was changed from

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache and to use an in-memory cache.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

BUG=455209
==========

[jif, 2016-02-25 10:01:47]

Description was changed from

==========
Enable Tab Switcher by default.

To do that, the snapshot_cache unittests needed to be fixed.
To do that, the snapshot_cache needed to be cleaned up:

-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the snapshot_cache
unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

BUG=455209
==========

[jif, 2016-02-25 10:02:00]

Description was changed from

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the snapshot_cache
unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

BUG=455209
==========

[jif, 2016-02-25 10:02:00]

jif@chromium.org changed reviewers:
+ jbbegue@chromium.org

[jif, 2016-02-25 10:02:15]

Patchset #1 (id:1) has been deleted

[jif, 2016-02-25 10:02:22]

Patchset #1 (id:20001) has been deleted

[jif, 2016-02-25 10:03:42]

sdefresne, PTAL again.

jbbegue, PTAL as well.

[sdefresne, 2016-02-25 10:08:10]

https://codereview.chromium.org/1725533004/diff/40001/ios/chrome/browser/snap...
File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right):

https://codereview.chromium.org/1725533004/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:29: // Promote some
implementation methods to public.
This is an anti-pattern. Please move this to snapshot_cache_internal.h and use
this from both this file and snapshot_cache.mm.

[jif-google, 2016-02-25 12:19:29]

Patchset #2 (id:60001) has been deleted

[jif-google, 2016-02-25 12:25:55]

Description was changed from

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=455209
==========

[jif-google, 2016-02-25 12:40:13]

Patchset #2 (id:80001) has been deleted

[jif-google, 2016-02-25 12:40:23]

Patchset #2 (id:100001) has been deleted

[jif-google, 2016-02-25 12:40:30]

Patchset #2 (id:120001) has been deleted

[jif-google, 2016-02-25 12:40:38]

Patchset #2 (id:140001) has been deleted

[jif-google, 2016-02-25 12:40:46]

Patchset #2 (id:160001) has been deleted

[jif, 2016-02-25 12:41:32]

Description was changed from

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=455209
==========

to

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[jif, 2016-02-25 12:42:29]

Thanks. PTAL.

https://codereview.chromium.org/1725533004/diff/40001/ios/chrome/browser/snap...
File ios/chrome/browser/snapshots/snapshot_cache_unittest.mm (right):

https://codereview.chromium.org/1725533004/diff/40001/ios/chrome/browser/snap...
ios/chrome/browser/snapshots/snapshot_cache_unittest.mm:29: // Promote some
implementation methods to public.
On 2016/02/25 10:08:09, sdefresne wrote:
> This is an anti-pattern. Please move this to snapshot_cache_internal.h and use
> this from both this file and snapshot_cache.mm.

Done.

[jif, 2016-02-25 12:43:20]

Description was changed from

==========
Enable Tab Switcher by default.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Enable iPad Tab Switcher by default on iOS.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[sdefresne, 2016-02-25 13:26:48]

lgtm

https://codereview.chromium.org/1725533004/diff/180001/ios/chrome/browser/sna...
File ios/chrome/browser/snapshots/snapshot_cache_internal.h (right):

https://codereview.chromium.org/1725533004/diff/180001/ios/chrome/browser/sna...
ios/chrome/browser/snapshots/snapshot_cache_internal.h:7: 
#import "ios/chrome/browser/snapshots/snapshot_cache_internal.h"

[jif-google, 2016-02-25 13:33:39]

The CQ bit was checked by jif@google.com

[jif-google, 2016-02-25 13:33:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1725533004/#ps200001
(title: "Addressed comment.")

[commit-bot: I haz the power, 2016-02-25 13:34:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725533004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725533004/200001

[commit-bot: I haz the power, 2016-02-25 14:19:01]

Description was changed from

==========
Enable iPad Tab Switcher by default on iOS.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Enable iPad Tab Switcher by default on iOS.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

[commit-bot: I haz the power, 2016-02-25 14:19:02]

Committed patchset #3 (id:200001)

[commit-bot: I haz the power, 2016-02-25 14:20:51]

Description was changed from

==========
Enable iPad Tab Switcher by default on iOS.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None
==========

to

==========
Enable iPad Tab Switcher by default on iOS.

Enabling the Tab Switcher by default required fixing the
snapshot_cache unittests.

In turn, this required fixing/cleaning the snapshot_cache:
-Always register/deregister for notifications.
-Centralize the logic to use a LRU cache.
-Centralize the logic to use an in-memory cache.

Other changes:
-Replaced msarda with jif in OWNERS
-Trigger memory warning instead of calling |handleLowMemory| from tests.

BUG=None

Committed: https://crrev.com/7bc8524f4e0b9fa3a7758a81f195a0228196b8d4
Cr-Commit-Position: refs/heads/master@{#377570}
==========

[commit-bot: I haz the power, 2016-02-25 14:20:53]

Patchset 3 (id:??) landed as
https://crrev.com/7bc8524f4e0b9fa3a7758a81f195a0228196b8d4
Cr-Commit-Position: refs/heads/master@{#377570}

[rohitrao (ping after 24h), 2016-02-27 02:09:02]

A revert of this CL (patchset #3 id:200001) has been created in
https://codereview.chromium.org/1740353002/ by rohitrao@chromium.org.

The reason for reverting is: Broke iOS UI tests downstream..