Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2394243002: Public Sessions whitelisting - removed privacy sensitive permissions (Closed)

Created:
4 years, 2 months ago by Ivan Šandrk
Modified:
4 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Public Sessions whitelisting - removed privacy sensitive permissions BUG=649726 Committed: https://crrev.com/f4e40ea6456093b50ff52a7df1eb59577c5e1904 Cr-Commit-Position: refs/heads/master@{#423827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ivan Šandrk
Drew, Vadym, please take a look! Thanks, Ivan
4 years, 2 months ago (2016-10-06 16:44:28 UTC) #3
dvadym
From privacy point of view LGTM Thanks!
4 years, 2 months ago (2016-10-06 16:48:05 UTC) #4
Andrew T Wilson (Slow)
lgtm
4 years, 2 months ago (2016-10-07 09:26:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394243002/1
4 years, 2 months ago (2016-10-07 09:31:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 09:55:24 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f4e40ea6456093b50ff52a7df1eb59577c5e1904 Cr-Commit-Position: refs/heads/master@{#423827}
4 years, 2 months ago (2016-10-07 09:57:43 UTC) #11
dvadym
4 years, 1 month ago (2016-10-24 13:11:46 UTC) #12
Message was sent while issue was closed. 
On 2016/10/07 09:57:43, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f4e40ea6456093b50ff52a7df1eb59577c5e1904
> Cr-Commit-Position: refs/heads/master@{#423827}

Could you please merge this CL in M-55? It's targeted for 55 launch, but it was
landed after M-55 branch point.

Powered by Google App Engine
This is Rietveld 408576698