Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2394243002: Public Sessions whitelisting - removed privacy sensitive permissions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
index dd2975c225ea9cc92e74998f65a0bf15bea821e9..d35ec8a0da585f21422fd3e841c3da7a583a4145 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
@@ -437,8 +437,8 @@ const char* const kSafePermissionStrings[] = {
"contentSettings",
- // Provides access to URLs.
- "contextMenus",
+ // Privacy sensitive URL access.
+ // "contextMenus",
// This would provie access to auth cookies, so needs to be blocked.
// "cookies",
@@ -512,8 +512,8 @@ const char* const kSafePermissionStrings[] = {
// However, keyboards and mice are apparently not surfaced via this API.
"hid",
- // Just URLs and meta data.
- "history",
+ // Privacy sensitive URL access.
+ // "history",
// Not really useful as there's no signed-in user, so OK to allow.
"identity",
@@ -598,8 +598,8 @@ const char* const kSafePermissionStrings[] = {
// that serial input devices are exceedingly rare, OK to allow.
"serial",
- // Access to URLs.
- "sessions",
+ // Privacy sensitive URL access.
+ // "sessions",
"socket",
@@ -629,11 +629,11 @@ const char* const kSafePermissionStrings[] = {
// for user consent or (2) return blank capture.
// "tabCapture",
- // URLs and page titles.
- "tabs",
+ // Privacy sensitive URL access.
+ // "tabs",
- // URLs and page titles.
- "topSites",
+ // Privacy sensitive URL access.
+ // "topSites",
// Allows to generate TTS, but no content access. Just UX.
"tts",
@@ -660,8 +660,8 @@ const char* const kSafePermissionStrings[] = {
// Just UX.
"wallpaper",
- // Access to URLs.
- "webNavigation",
+ // Privacy sensitive URL access.
+ // "webNavigation",
// Provides access to cookies and form upload data. Options: (1) block,
// (2) strip all content in events.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698