Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/formats/mpeg/mp3_stream_parser_unittest.cc

Issue 239423005: Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch codec_delay() to frames. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/opus_audio_decoder.cc ('K') | « media/formats/mpeg/mp3_stream_parser.cc ('k') | media/formats/mpeg/mpeg_audio_stream_parser_base.h » ('j') | media/formats/webm/webm_audio_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mpeg/mp3_stream_parser_unittest.cc
diff --git a/media/formats/mpeg/mp3_stream_parser_unittest.cc b/media/formats/mpeg/mp3_stream_parser_unittest.cc
index 85cc129fe158288d540c6b5c96f3babfc2788d87..2e2179649a4c911bae0fd9736b63ada8918be161 100644
--- a/media/formats/mpeg/mp3_stream_parser_unittest.cc
+++ b/media/formats/mpeg/mp3_stream_parser_unittest.cc
@@ -40,6 +40,7 @@ TEST_F(MP3StreamParserTest, UnalignedAppend) {
"{ 0K }"
"EndOfSegment";
EXPECT_EQ(expected, ParseFile("sfx.mp3", 17));
+ EXPECT_GT(last_audio_config_.codec_delay(), 0);
}
// Test parsing with a larger piece size to verify that multiple buffers
@@ -56,6 +57,7 @@ TEST_F(MP3StreamParserTest, UnalignedAppend512) {
"{ 0K }"
"EndOfSegment";
EXPECT_EQ(expected, ParseFile("sfx.mp3", 512));
+ EXPECT_GT(last_audio_config_.codec_delay(), 0);
}
} // namespace media
« media/filters/opus_audio_decoder.cc ('K') | « media/formats/mpeg/mp3_stream_parser.cc ('k') | media/formats/mpeg/mpeg_audio_stream_parser_base.h » ('j') | media/formats/webm/webm_audio_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698