Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: media/formats/mpeg/mp3_stream_parser_unittest.cc

Issue 239423005: Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch codec_delay() to frames. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/formats/common/stream_parser_test_base.h" 5 #include "media/formats/common/stream_parser_test_base.h"
6 #include "media/formats/mpeg/mp3_stream_parser.h" 6 #include "media/formats/mpeg/mp3_stream_parser.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace media { 9 namespace media {
10 10
(...skipping 22 matching lines...) Expand all
33 "NewSegment" 33 "NewSegment"
34 "{ 0K }" 34 "{ 0K }"
35 "{ 0K }" 35 "{ 0K }"
36 "{ 0K }" 36 "{ 0K }"
37 "EndOfSegment" 37 "EndOfSegment"
38 "NewSegment" 38 "NewSegment"
39 "{ 0K }" 39 "{ 0K }"
40 "{ 0K }" 40 "{ 0K }"
41 "EndOfSegment"; 41 "EndOfSegment";
42 EXPECT_EQ(expected, ParseFile("sfx.mp3", 17)); 42 EXPECT_EQ(expected, ParseFile("sfx.mp3", 17));
43 EXPECT_GT(last_audio_config_.codec_delay(), 0);
43 } 44 }
44 45
45 // Test parsing with a larger piece size to verify that multiple buffers 46 // Test parsing with a larger piece size to verify that multiple buffers
46 // are passed to |new_buffer_cb_|. 47 // are passed to |new_buffer_cb_|.
47 TEST_F(MP3StreamParserTest, UnalignedAppend512) { 48 TEST_F(MP3StreamParserTest, UnalignedAppend512) {
48 const std::string expected = 49 const std::string expected =
49 "NewSegment" 50 "NewSegment"
50 "{ 0K }" 51 "{ 0K }"
51 "{ 0K 26K 52K 78K }" 52 "{ 0K 26K 52K 78K }"
52 "EndOfSegment" 53 "EndOfSegment"
53 "NewSegment" 54 "NewSegment"
54 "{ 0K 26K 52K }" 55 "{ 0K 26K 52K }"
55 "{ 0K 26K 52K 78K }" 56 "{ 0K 26K 52K 78K }"
56 "{ 0K }" 57 "{ 0K }"
57 "EndOfSegment"; 58 "EndOfSegment";
58 EXPECT_EQ(expected, ParseFile("sfx.mp3", 512)); 59 EXPECT_EQ(expected, ParseFile("sfx.mp3", 512));
60 EXPECT_GT(last_audio_config_.codec_delay(), 0);
59 } 61 }
60 62
61 } // namespace media 63 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698