Chromium Code Reviews
DescriptionFix null reference issues in bazel.dart.
There were two issues:
- We were trying to use `parent` before null checking it.
- In the event that no workspace root could be found, we were returning
`null` from the BazelWorkspace factory constructor. This CL changes
the behavior so that we return a BazelWorkspace that has no special
bin or genfiles behaviors.
R=scheglov@google.com
Committed: https://github.com/dart-lang/sdk/commit/f9c819057bb5fda598a33d97ebf9418f36cd0932
Patch Set 1 #Patch Set 2 : Fix broken test #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||