Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2394213002: Fix null reference issues in bazel.dart. (Closed)

Created:
4 years, 2 months ago by Paul Berry
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix null reference issues in bazel.dart. There were two issues: - We were trying to use `parent` before null checking it. - In the event that no workspace root could be found, we were returning `null` from the BazelWorkspace factory constructor. This CL changes the behavior so that we return a BazelWorkspace that has no special bin or genfiles behaviors. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f9c819057bb5fda598a33d97ebf9418f36cd0932

Patch Set 1 #

Patch Set 2 : Fix broken test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 2 months ago (2016-10-06 15:51:27 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-06 15:53:29 UTC) #3
Brian Wilkerson
> ... we return a BazelWorkspace that has no special bin or genfiles behaviors. What ...
4 years, 2 months ago (2016-10-06 15:55:02 UTC) #4
Paul Berry
4 years, 2 months ago (2016-10-06 21:21:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9c819057bb5fda598a33d97ebf9418f36cd0932 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698