Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: pkg/analyzer/test/generated/bazel_test.dart

Issue 2394213002: Fix null reference issues in bazel.dart. (Closed)
Patch Set: Fix broken test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/bazel.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/bazel_test.dart
diff --git a/pkg/analyzer/test/generated/bazel_test.dart b/pkg/analyzer/test/generated/bazel_test.dart
index 758b47c452ac703dacdbfd2981a6c94ca9bc276a..91a9d1754f6954337ae258dfc4cf358db13aac26 100644
--- a/pkg/analyzer/test/generated/bazel_test.dart
+++ b/pkg/analyzer/test/generated/bazel_test.dart
@@ -144,10 +144,14 @@ class BazelWorkspaceTest extends _BaseTest {
expect(workspace.genfiles, _p('/workspace/bazel-genfiles'));
}
- void test_factory_null_notInWorkspace() {
+ void test_factory_notInWorkspace() {
BazelWorkspace workspace =
new BazelWorkspace(provider, _p('/workspace/my/module'));
- expect(workspace, isNull);
+ expect(workspace, isNotNull);
+ expect(workspace.root, _p('/workspace/my/module'));
+ expect(workspace.readonly, isNull);
+ expect(workspace.bin, isNull);
+ expect(workspace.genfiles, isNull);
}
void test_factory_symlinkPrefix() {
« no previous file with comments | « pkg/analyzer/lib/src/generated/bazel.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698