Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2394143004: Harmony - Update anchors for the rest of the location bar icons that (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmony - Update anchors for the rest of the location bar icons that show bubbles. BUG=635172 Committed: https://crrev.com/a5b678c030986c136a5696b7287d399d85032dab Cr-Commit-Position: refs/heads/master@{#424615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix zoom #

Patch Set 3 : actually fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -72 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 3 chunks +7 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 2 7 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 3 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 3 chunks +40 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Evan Stade
4 years, 2 months ago (2016-10-06 21:01:03 UTC) #2
msw
lgtm with a q; sorry this fell off my plate. https://codereview.chromium.org/2394143004/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc File chrome/browser/ui/views/location_bar/zoom_bubble_view.cc (right): https://codereview.chromium.org/2394143004/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc#newcode50 ...
4 years, 2 months ago (2016-10-11 17:04:54 UTC) #7
Evan Stade
https://codereview.chromium.org/2394143004/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc File chrome/browser/ui/views/location_bar/zoom_bubble_view.cc (right): https://codereview.chromium.org/2394143004/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc#newcode50 chrome/browser/ui/views/location_bar/zoom_bubble_view.cc:50: views::View* anchor_view = On 2016/10/11 17:04:54, msw wrote: > ...
4 years, 2 months ago (2016-10-11 23:49:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394143004/40001
4 years, 2 months ago (2016-10-11 23:50:21 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-12 00:41:21 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 00:45:39 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a5b678c030986c136a5696b7287d399d85032dab
Cr-Commit-Position: refs/heads/master@{#424615}

Powered by Google App Engine
This is Rietveld 408576698