Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2394143004: Harmony - Update anchors for the rest of the location bar icons that (Closed)
Patch Set: actually fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/content_setting_image_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <memory> 10 #include <memory>
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 #include "chrome/browser/ui/browser_list.h" 54 #include "chrome/browser/ui/browser_list.h"
55 #include "chrome/browser/ui/browser_window_state.h" 55 #include "chrome/browser/ui/browser_window_state.h"
56 #include "chrome/browser/ui/search/search_delegate.h" 56 #include "chrome/browser/ui/search/search_delegate.h"
57 #include "chrome/browser/ui/search/search_model.h" 57 #include "chrome/browser/ui/search/search_model.h"
58 #include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h" 58 #include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"
59 #include "chrome/browser/ui/tabs/tab_menu_model.h" 59 #include "chrome/browser/ui/tabs/tab_menu_model.h"
60 #include "chrome/browser/ui/tabs/tab_strip_model.h" 60 #include "chrome/browser/ui/tabs/tab_strip_model.h"
61 #include "chrome/browser/ui/view_ids.h" 61 #include "chrome/browser/ui/view_ids.h"
62 #include "chrome/browser/ui/views/accelerator_table.h" 62 #include "chrome/browser/ui/views/accelerator_table.h"
63 #include "chrome/browser/ui/views/accessibility/invert_bubble_view.h" 63 #include "chrome/browser/ui/views/accessibility/invert_bubble_view.h"
64 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h"
65 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" 64 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
66 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" 65 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
67 #include "chrome/browser/ui/views/download/download_in_progress_dialog_view.h" 66 #include "chrome/browser/ui/views/download/download_in_progress_dialog_view.h"
68 #include "chrome/browser/ui/views/download/download_shelf_view.h" 67 #include "chrome/browser/ui/views/download/download_shelf_view.h"
69 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h" 68 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
70 #include "chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h" 69 #include "chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h"
71 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views .h" 70 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views .h"
72 #include "chrome/browser/ui/views/find_bar_host.h" 71 #include "chrome/browser/ui/views/find_bar_host.h"
73 #include "chrome/browser/ui/views/frame/browser_view_layout.h" 72 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
74 #include "chrome/browser/ui/views/frame/browser_view_layout_delegate.h" 73 #include "chrome/browser/ui/views/frame/browser_view_layout_delegate.h"
(...skipping 1167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 const WebApplicationInfo& web_app_info, 1241 const WebApplicationInfo& web_app_info,
1243 const ShowBookmarkAppBubbleCallback& callback) { 1242 const ShowBookmarkAppBubbleCallback& callback) {
1244 BookmarkAppConfirmationView::CreateAndShow(GetNativeWindow(), web_app_info, 1243 BookmarkAppConfirmationView::CreateAndShow(GetNativeWindow(), web_app_info,
1245 callback); 1244 callback);
1246 } 1245 }
1247 1246
1248 autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble( 1247 autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble(
1249 content::WebContents* web_contents, 1248 content::WebContents* web_contents,
1250 autofill::SaveCardBubbleController* controller, 1249 autofill::SaveCardBubbleController* controller,
1251 bool is_user_gesture) { 1250 bool is_user_gesture) {
1252 views::View* anchor_view = toolbar_->GetSaveCreditCardBubbleAnchor(); 1251 return toolbar_->ShowSaveCreditCardBubble(web_contents, controller,
1253 autofill::SaveCardBubbleViews* view = new autofill::SaveCardBubbleViews( 1252 is_user_gesture);
1254 anchor_view, web_contents, controller);
1255 toolbar_->OnBubbleCreatedForAnchor(anchor_view, view->GetWidget());
1256 view->Show(is_user_gesture ? autofill::SaveCardBubbleViews::USER_GESTURE
1257 : autofill::SaveCardBubbleViews::AUTOMATIC);
1258 return view;
1259 } 1253 }
1260 1254
1261 void BrowserView::ShowTranslateBubble( 1255 void BrowserView::ShowTranslateBubble(
1262 content::WebContents* web_contents, 1256 content::WebContents* web_contents,
1263 translate::TranslateStep step, 1257 translate::TranslateStep step,
1264 translate::TranslateErrors::Type error_type, 1258 translate::TranslateErrors::Type error_type,
1265 bool is_user_gesture) { 1259 bool is_user_gesture) {
1266 if (contents_web_view_->HasFocus() && 1260 if (contents_web_view_->HasFocus() &&
1267 !GetLocationBarView()->IsMouseHovered()) { 1261 !GetLocationBarView()->IsMouseHovered()) {
1268 content::RenderViewHost* rvh = web_contents->GetRenderViewHost(); 1262 content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
1269 if (rvh->IsFocusedElementEditable()) 1263 if (rvh->IsFocusedElementEditable())
1270 return; 1264 return;
1271 } 1265 }
1272 1266
1273 ChromeTranslateClient* chrome_translate_client =
1274 ChromeTranslateClient::FromWebContents(web_contents);
1275 translate::LanguageState& language_state = 1267 translate::LanguageState& language_state =
1276 chrome_translate_client->GetLanguageState(); 1268 ChromeTranslateClient::FromWebContents(web_contents)->GetLanguageState();
1277 language_state.SetTranslateEnabled(true); 1269 language_state.SetTranslateEnabled(true);
1278 1270
1279 if (IsMinimized()) 1271 if (!IsMinimized()) {
1280 return; 1272 toolbar_->ShowTranslateBubble(web_contents, step, error_type,
1281 1273 is_user_gesture);
1282 views::View* anchor_view = toolbar_->GetTranslateBubbleAnchor(); 1274 }
1283 views::Widget* bubble_widget = TranslateBubbleView::ShowBubble(
1284 anchor_view, web_contents, step,
1285 error_type, is_user_gesture ? TranslateBubbleView::USER_GESTURE
1286 : TranslateBubbleView::AUTOMATIC);
1287 toolbar_->OnBubbleCreatedForAnchor(anchor_view, bubble_widget);
1288 } 1275 }
1289 1276
1290 #if BUILDFLAG(ENABLE_ONE_CLICK_SIGNIN) 1277 #if BUILDFLAG(ENABLE_ONE_CLICK_SIGNIN)
1291 void BrowserView::ShowOneClickSigninConfirmation( 1278 void BrowserView::ShowOneClickSigninConfirmation(
1292 const base::string16& email, 1279 const base::string16& email,
1293 const StartSyncCallback& start_sync_callback) { 1280 const StartSyncCallback& start_sync_callback) {
1294 std::unique_ptr<OneClickSigninLinksDelegate> delegate( 1281 std::unique_ptr<OneClickSigninLinksDelegate> delegate(
1295 new OneClickSigninLinksDelegateImpl(browser())); 1282 new OneClickSigninLinksDelegateImpl(browser()));
1296 OneClickSigninDialogView::ShowDialog(email, std::move(delegate), 1283 OneClickSigninDialogView::ShowDialog(email, std::move(delegate),
1297 GetNativeWindow(), start_sync_callback); 1284 GetNativeWindow(), start_sync_callback);
(...skipping 1351 matching lines...) Expand 10 before | Expand all | Expand 10 after
2649 } 2636 }
2650 2637
2651 extensions::ActiveTabPermissionGranter* 2638 extensions::ActiveTabPermissionGranter*
2652 BrowserView::GetActiveTabPermissionGranter() { 2639 BrowserView::GetActiveTabPermissionGranter() {
2653 content::WebContents* web_contents = GetActiveWebContents(); 2640 content::WebContents* web_contents = GetActiveWebContents();
2654 if (!web_contents) 2641 if (!web_contents)
2655 return nullptr; 2642 return nullptr;
2656 return extensions::TabHelper::FromWebContents(web_contents) 2643 return extensions::TabHelper::FromWebContents(web_contents)
2657 ->active_tab_permission_granter(); 2644 ->active_tab_permission_granter();
2658 } 2645 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/content_setting_image_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698