Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 2394103002: Fix for the missing new keyword on an external factory call and updated expected test failures/e… (Closed)

Created:
4 years, 2 months ago by nshahan
Modified:
4 years, 2 months ago
Reviewers:
vsm, Jacob, jacob314
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for the missing new keyword on an external factory call. Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test Fixes #27443 R=jacob314@gmail.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/0132d6114ad03477d022a442f0af0774dddb83ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 3 chunks +8 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart View 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
vsm
lgtm
4 years, 2 months ago (2016-10-06 14:48:11 UTC) #3
jacob314
lgtm lgtm. Can you go ahead and update /html/js_typed_interop_test.dart as well so that the test ...
4 years, 2 months ago (2016-10-06 15:43:54 UTC) #5
nshahan
On 2016/10/06 15:43:54, jacob314 wrote: > lgtm > > lgtm. > Can you go ahead ...
4 years, 2 months ago (2016-10-06 17:21:05 UTC) #6
nshahan
4 years, 2 months ago (2016-10-06 17:24:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0132d6114ad03477d022a442f0af0774dddb83ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698