Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1722)

Unified Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2394103002: Fix for the missing new keyword on an external factory call and updated expected test failures/e… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/browser/language_tests.js
diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js
index 788af22724253b47c908ac4348ab227d36a0b44e..cd127e6dbe82deef8013fe25b1e495b550702227 100644
--- a/pkg/dev_compiler/test/browser/language_tests.js
+++ b/pkg/dev_compiler/test/browser/language_tests.js
@@ -27,8 +27,8 @@ define(['dart_sdk', 'async_helper', 'unittest', 'require'],
// The number of expected unittest errors should be zero but unfortunately
// there are a lot of broken html unittests.
- let num_expected_unittest_fails = 3;
- let num_expected_unittest_errors = 2;
+ let num_expected_unittest_fails = 5;
+ let num_expected_unittest_errors = 8;
// TODO(jmesserly): separate StrongModeError from other errors.
let all_status = {
@@ -495,7 +495,7 @@ define(['dart_sdk', 'async_helper', 'unittest', 'require'],
'js_typed_interop_default_arg_test': 'unittest',
'js_typed_interop_side_cast_exp_test': 'unittest',
'js_typed_interop_side_cast_test': 'unittest',
- 'js_typed_interop_test': ['unittest', 'skip', 'fail'],
+ 'js_typed_interop_test': 'unittest',
'keyboard_event_test': ['unittest', 'skip', 'fail'],
'localstorage_test': ['unittest', 'skip', 'fail'],
'location_test': ['unittest', 'skip', 'fail'],

Powered by Google App Engine
This is Rietveld 408576698