RenderWidget::windowRect and viewRect should apply device emulation transform.

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 1318 matching lines @@
 void RenderWidget::Close() {
   screen_metrics_emulator_.reset();
   WillCloseLayerTreeView();
   compositor_.reset();
   if (webwidget_internal_) {
     webwidget_internal_->close();
     webwidget_internal_ = nullptr;
   }
 }
 
+void RenderWidget::ApplyWindowEmulation(WebRect* window_rect) const {
+  DCHECK(window_rect);
+  float scale = popup_origin_scale_for_emulation_;
+  window_rect->x =
+      popup_view_origin_for_emulation_.x() +
+      (window_rect->x - popup_screen_origin_for_emulation_.x()) / scale;
+  window_rect->y =
+      popup_view_origin_for_emulation_.y() +
+      (window_rect->y - popup_screen_origin_for_emulation_.y()) / scale;
+}
+
+void RenderWidget::RemoveWindowEmulation(WebRect* window_rect) const {
+  DCHECK(window_rect);
+  float scale = popup_origin_scale_for_emulation_;
+  window_rect->x =
+      popup_screen_origin_for_emulation_.x() +
+      (window_rect->x - popup_view_origin_for_emulation_.x()) * scale;
+  window_rect->y =
+      popup_screen_origin_for_emulation_.y() +
+      (window_rect->y - popup_view_origin_for_emulation_.y()) * scale;
+}
+
 WebRect RenderWidget::windowRect() {
+  WebRect rect;
   if (pending_window_rect_count_) {
     // NOTE(mbelshe): If there is a pending_window_rect_, then getting
     // the RootWindowRect is probably going to return wrong results since the
     // browser may not have processed the Move yet.  There isn't really anything
     // good to do in this case, and it shouldn't happen - since this size is
     // only really needed for windowToScreen, which is only used for Popups.
-    return pending_window_rect_;
+    rect = pending_window_rect_;
+  } else {
+    rect = window_screen_rect_;
   }
 
-  return window_screen_rect_;
+  if (popup_origin_scale_for_emulation_)

[dgozman, 2016/10/05 22:40:20]

Let's maybe call the method unconditionally and early return from it if no
emulation?

[bokan, 2016/10/05 22:49:42]

Done but added |IfNeeded| to the method name to make it clear it's conditional.

+    ApplyWindowEmulation(&rect);
+
+  return rect;
 }
 
 WebRect RenderWidget::viewRect() {
-    return view_screen_rect_;
+  WebRect rect = view_screen_rect_;
+  if (popup_origin_scale_for_emulation_)
+    ApplyWindowEmulation(&rect);

[dgozman, 2016/10/05 22:40:20]

ScreenRectToEmulated? It's easier to understand conversion methods when they
mention from what to what they convert.

[bokan, 2016/10/05 22:49:42]

Done.

+
+  return rect;
 }
 
 void RenderWidget::setToolTipText(const blink::WebString& text,
                                   WebTextDirection hint) {
   Send(new ViewHostMsg_SetTooltipText(routing_id_, text, hint));
 }
 
 void RenderWidget::setWindowRect(const WebRect& rect_in_screen) {
   WebRect window_rect = rect_in_screen;
-  if (popup_origin_scale_for_emulation_) {
-    float scale = popup_origin_scale_for_emulation_;
-    window_rect.x = popup_screen_origin_for_emulation_.x() +
-        (window_rect.x - popup_view_origin_for_emulation_.x()) * scale;
-    window_rect.y = popup_screen_origin_for_emulation_.y() +
-        (window_rect.y - popup_view_origin_for_emulation_.y()) * scale;
-  }
+  if (popup_origin_scale_for_emulation_)
+    RemoveWindowEmulation(&window_rect);

[dgozman, 2016/10/05 22:40:20]

EmulatedRectToScreen

[bokan, 2016/10/05 22:49:42]

Done.

 
   if (!resizing_mode_selector_->is_synchronous_mode()) {
     if (did_show_) {
       Send(new ViewHostMsg_RequestMove(routing_id_, window_rect));
       SetPendingWindowRect(window_rect);
     } else {
       initial_rect_ = window_rect;
     }
   } else {
     SetWindowRectSynchronously(window_rect);
@@ skipping 787 matching lines @@
 bool RenderWidget::isPointerLocked() {
   return mouse_lock_dispatcher_->IsMouseLockedTo(
       webwidget_mouse_lock_target_.get());
 }
 
 blink::WebWidget* RenderWidget::GetWebWidget() const {
   return webwidget_internal_;
 }
 
 }  // namespace content