Issue 2394033003: Remove SVN (and dcommit) support from git-cl

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -1161 lines)			Patch
M	PRESUBMIT.py	View	1 2 3	1 chunk	+4 lines, -5 lines	0 comments	Download
M	git_cl.py	View	1 2 3 4 5	22 chunks	+92 lines, -334 lines	0 comments	Download
M	tests/abandon.sh	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/basic.sh	View	1 2	3 chunks	+14 lines, -12 lines	0 comments	Download
M	tests/git_cl_test.py	View	1 2 3 4 5	3 chunks	+1 line, -450 lines	0 comments	Download
M	tests/hooks.sh	View	1 2	2 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/owners.sh	View	1 2 3	2 chunks	+5 lines, -12 lines	0 comments	Download
M	tests/patch.sh	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
D	tests/post-dcommit-hook-test.sh	View	1 2	1 chunk	+0 lines, -42 lines	0 comments	Download
A +	tests/post-land-hook-test.sh	View	1 2	1 chunk	+9 lines, -9 lines	0 comments	Download
D	tests/push-basic.sh	View	1 2	1 chunk	+0 lines, -70 lines	0 comments	Download
M	tests/push-from-logs.sh	View	1 2 3	3 chunks	+20 lines, -19 lines	0 comments	Download
M	tests/rename.sh	View	1 2 3	1 chunk	+0 lines, -40 lines	0 comments	Download
M	tests/save-description-on-failure.sh	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/submit-from-new-dir.sh	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
D	tests/submodule-merge-test.sh	View	1 2	1 chunk	+0 lines, -60 lines	0 comments	Download
M	tests/test-lib.sh	View	1 2	2 chunks	+10 lines, -80 lines	0 comments	Download
M	tests/upload-local-tracking-branch.sh	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/upload-stale.sh	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 11 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

agable

Haven't gone after the tests yet, but feel free to take a look to make ...

4 years, 2 months ago (2016-10-05 23:04:30 UTC) #1

tandrii(chromium)

looks good so far https://codereview.chromium.org/2394033003/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2394033003/diff/20001/git_cl.py#newcode4190 git_cl.py:4190: print(message) I'd add return 1 ...

4 years, 2 months ago (2016-10-06 08:04:01 UTC) #2

agable

I've added the fixes for the tests now, too. https://codereview.chromium.org/2394033003/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2394033003/diff/20001/git_cl.py#newcode4190 git_cl.py:4190: ...

4 years, 2 months ago (2016-10-06 21:43:15 UTC) #3

tandrii(chromium)

Very nice, in hindsight test fixes look so simple. Thanks!

4 years, 2 months ago (2016-10-07 13:17:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394033003/80001

4 years ago (2016-11-29 22:51:30 UTC) #8

commit-bot: I haz the power

Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/32cb1afc704f6d10)

4 years ago (2016-11-29 22:57:40 UTC) #10

agable

4 years ago (2016-11-30 00:11:48 UTC) #11

On 2016/11/29 at 22:57:40, commit-bot wrote:
> Try jobs failed on following builders:
>   Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/32cb1afc704f6d10)

Dammit, that test passes locally. I don't know what's different on the swarming
bot.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2394033003: Remove SVN (and dcommit) support from git-cl (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Patch Set 3 : Remove dcommit tests and git-svn test assumptions #

Patch Set 4 : Updated patchset dependency #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Messages