Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: PRESUBMIT.py

Issue 2394033003: Remove SVN (and dcommit) support from git-cl (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index f082fb010603da8962327f7f7096ca8a13bfba2d..998d9b38dc77527d720ab908ba939a31dce0ebe5 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -86,12 +86,11 @@ def RunGitClTests(input_api, output_api):
server.start_server()
test_path = input_api.os_path.abspath(
input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'))
+
+ # test-lib.sh is not an actual test so it should not be run.
+ NON_TEST_FILES = ('test-lib.sh')
for test in input_api.os_listdir(test_path):
- # test-lib.sh is not an actual test so it should not be run. The other
- # tests are tests known to fail.
- DISABLED_TESTS = (
- 'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh')
- if test in DISABLED_TESTS or not test.endswith('.sh'):
+ if test in NON_TEST_FILES or not test.endswith('.sh'):
continue
print('Running %s' % test)
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698