Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239393009: Don't crash when closing interstitial pages. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Don't crash when closing interstitial pages. BUG=363564 TEST=as in bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266759

Patch Set 1 #

Patch Set 2 : crash fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M content/browser/frame_host/interstitial_page_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Avi (use Gerrit)
6 years, 8 months ago (2014-04-15 22:20:37 UTC) #1
jam
lgtm
6 years, 8 months ago (2014-04-16 00:12:12 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-16 00:19:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/239393009/1
6 years, 8 months ago (2014-04-16 00:20:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/239393009/1
6 years, 8 months ago (2014-04-16 01:35:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 02:52:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-16 02:52:41 UTC) #7
Avi (use Gerrit)
John, PTAL. I need to keep both, as InterstitialPageImpl needs to get a teardown notice ...
6 years, 7 months ago (2014-04-29 03:42:13 UTC) #8
jam
On 2014/04/29 03:42:13, Avi wrote: > John, PTAL. I need to keep both, as InterstitialPageImpl ...
6 years, 7 months ago (2014-04-29 03:58:17 UTC) #9
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-04-29 04:00:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/239393009/20001
6 years, 7 months ago (2014-04-29 04:00:55 UTC) #11
commit-bot: I haz the power
Change committed as 266759
6 years, 7 months ago (2014-04-29 07:20:59 UTC) #12
zverre
6 years, 7 months ago (2014-04-29 10:44:17 UTC) #13
Message was sent while issue was closed. 
On 2014/04/29 04:00:13, Avi wrote:
> The CQ bit was checked by mailto:avi@chromium.org

Hi, I think that we should look at this problem a little bit wider. We still can
have problems because WebContentsObservers can call (directly or indirectly)
each other during destruction of WebContents and thus might result in new
problems. Please take a look at my CL https://codereview.chromium.org/257153003
and give some feedback.

Powered by Google App Engine
This is Rietveld 408576698