Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 239393009: Don't crash when closing interstitial pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: crash fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 virtual void Show() OVERRIDE; 62 virtual void Show() OVERRIDE;
63 virtual void Hide() OVERRIDE; 63 virtual void Hide() OVERRIDE;
64 virtual void DontProceed() OVERRIDE; 64 virtual void DontProceed() OVERRIDE;
65 virtual void Proceed() OVERRIDE; 65 virtual void Proceed() OVERRIDE;
66 virtual RenderViewHost* GetRenderViewHostForTesting() const OVERRIDE; 66 virtual RenderViewHost* GetRenderViewHostForTesting() const OVERRIDE;
67 virtual InterstitialPageDelegate* GetDelegateForTesting() OVERRIDE; 67 virtual InterstitialPageDelegate* GetDelegateForTesting() OVERRIDE;
68 virtual void DontCreateViewForTesting() OVERRIDE; 68 virtual void DontCreateViewForTesting() OVERRIDE;
69 virtual void SetSize(const gfx::Size& size) OVERRIDE; 69 virtual void SetSize(const gfx::Size& size) OVERRIDE;
70 virtual void Focus() OVERRIDE; 70 virtual void Focus() OVERRIDE;
71 71
72 // This is called by a hosting WebContents to notify this interstitial page
73 // that it is going away.
74 void WebContentsWillBeDestroyed();
75
72 // Allows the user to navigate away by disabling the interstitial, canceling 76 // Allows the user to navigate away by disabling the interstitial, canceling
73 // the pending request, and unblocking the hidden renderer. The interstitial 77 // the pending request, and unblocking the hidden renderer. The interstitial
74 // will stay visible until the navigation completes. 78 // will stay visible until the navigation completes.
75 void CancelForNavigation(); 79 void CancelForNavigation();
76 80
77 // Focus the first (last if reverse is true) element in the interstitial page. 81 // Focus the first (last if reverse is true) element in the interstitial page.
78 // Called when tab traversing. 82 // Called when tab traversing.
79 void FocusThroughTabTraversal(bool reverse); 83 void FocusThroughTabTraversal(bool reverse);
80 84
81 RenderWidgetHostView* GetView(); 85 RenderWidgetHostView* GetView();
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 base::WeakPtrFactory<InterstitialPageImpl> weak_ptr_factory_; 287 base::WeakPtrFactory<InterstitialPageImpl> weak_ptr_factory_;
284 288
285 scoped_refptr<SessionStorageNamespace> session_storage_namespace_; 289 scoped_refptr<SessionStorageNamespace> session_storage_namespace_;
286 290
287 DISALLOW_COPY_AND_ASSIGN(InterstitialPageImpl); 291 DISALLOW_COPY_AND_ASSIGN(InterstitialPageImpl);
288 }; 292 };
289 293
290 } // namespace content 294 } // namespace content
291 295
292 #endif // CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_ 296 #endif // CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698