third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp - Issue 2393923002: Add unit tests for webrtc_media_stream_adapter.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

Issue 2393923002: Add unit tests for webrtc_media_stream_adapter.cc (Closed)

Patch Set: Addressed review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

index 5f6f8af0243977a48ea92d64d0a5a1979227f5cf..630ae94e74a1a6525f6be238238380501b1aa617 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

@@ -117,6 +117,7 @@ const char kUseRtpMux[] = "googUseRtpMUX";

const char kEnableDtlsSrtp[] = "DtlsSrtpKeyAgreement";

const char kEnableRtpDataChannels[] = "RtpDataChannels";

// Google-specific constraint keys.

+// These need to be made standard or deleted. crbug.com/605673

pbos 2016/10/10 15:43:33 this should be in TODO(hta) format

hta - Chromium 2016/10/10 18:59:01 Done.

const char kEnableDscp[] = "googDscp";

const char kEnableIPv6[] = "googIPv6";

const char kEnableVideoSuspendBelowMinBitrate[] = "googSuspendBelowMinBitrate";

« content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc ('K') | « content/test/BUILD.gn ('k') | no next file » | no next file with comments »