Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

Issue 2393923002: Add unit tests for webrtc_media_stream_adapter.cc (Closed)
Patch Set: Addressed review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 const char kOfferToReceiveAudio[] = "OfferToReceiveAudio"; 110 const char kOfferToReceiveAudio[] = "OfferToReceiveAudio";
111 const char kOfferToReceiveVideo[] = "OfferToReceiveVideo"; 111 const char kOfferToReceiveVideo[] = "OfferToReceiveVideo";
112 const char kVoiceActivityDetection[] = "VoiceActivityDetection"; 112 const char kVoiceActivityDetection[] = "VoiceActivityDetection";
113 const char kIceRestart[] = "IceRestart"; 113 const char kIceRestart[] = "IceRestart";
114 // Google specific constraint for BUNDLE enable/disable. 114 // Google specific constraint for BUNDLE enable/disable.
115 const char kUseRtpMux[] = "googUseRtpMUX"; 115 const char kUseRtpMux[] = "googUseRtpMUX";
116 // Below constraints should be used during PeerConnection construction. 116 // Below constraints should be used during PeerConnection construction.
117 const char kEnableDtlsSrtp[] = "DtlsSrtpKeyAgreement"; 117 const char kEnableDtlsSrtp[] = "DtlsSrtpKeyAgreement";
118 const char kEnableRtpDataChannels[] = "RtpDataChannels"; 118 const char kEnableRtpDataChannels[] = "RtpDataChannels";
119 // Google-specific constraint keys. 119 // Google-specific constraint keys.
120 // These need to be made standard or deleted. crbug.com/605673
pbos 2016/10/10 15:43:33 this should be in TODO(hta) format
hta - Chromium 2016/10/10 18:59:01 Done.
120 const char kEnableDscp[] = "googDscp"; 121 const char kEnableDscp[] = "googDscp";
121 const char kEnableIPv6[] = "googIPv6"; 122 const char kEnableIPv6[] = "googIPv6";
122 const char kEnableVideoSuspendBelowMinBitrate[] = "googSuspendBelowMinBitrate"; 123 const char kEnableVideoSuspendBelowMinBitrate[] = "googSuspendBelowMinBitrate";
123 const char kNumUnsignalledRecvStreams[] = "googNumUnsignalledRecvStreams"; 124 const char kNumUnsignalledRecvStreams[] = "googNumUnsignalledRecvStreams";
124 const char kCombinedAudioVideoBwe[] = "googCombinedAudioVideoBwe"; 125 const char kCombinedAudioVideoBwe[] = "googCombinedAudioVideoBwe";
125 const char kScreencastMinBitrate[] = "googScreencastMinBitrate"; 126 const char kScreencastMinBitrate[] = "googScreencastMinBitrate";
126 const char kCpuOveruseDetection[] = "googCpuOveruseDetection"; 127 const char kCpuOveruseDetection[] = "googCpuOveruseDetection";
127 const char kCpuUnderuseThreshold[] = "googCpuUnderuseThreshold"; 128 const char kCpuUnderuseThreshold[] = "googCpuUnderuseThreshold";
128 const char kCpuOveruseThreshold[] = "googCpuOveruseThreshold"; 129 const char kCpuOveruseThreshold[] = "googCpuOveruseThreshold";
129 const char kCpuUnderuseEncodeRsdThreshold[] = 130 const char kCpuUnderuseEncodeRsdThreshold[] =
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 MediaTrackConstraintSet element; 795 MediaTrackConstraintSet element;
795 convertConstraintSet(it, element); 796 convertConstraintSet(it, element);
796 advancedVector.append(element); 797 advancedVector.append(element);
797 } 798 }
798 if (!advancedVector.isEmpty()) 799 if (!advancedVector.isEmpty())
799 output.setAdvanced(advancedVector); 800 output.setAdvanced(advancedVector);
800 } 801 }
801 802
802 } // namespace MediaConstraintsImpl 803 } // namespace MediaConstraintsImpl
803 } // namespace blink 804 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698