[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
Committed: https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff
Cr-Commit-Position: refs/heads/master@{#423379}

[chongz, 2016-10-05 15:38:34]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[chongz, 2016-10-05 15:38:56]

Description was changed from

==========
Fix debug tests and DCHECK for "inputevent-drag-drop.html"

On debug mode the tests might start before image/document is loaded.

This CL changed the tests to use styled text instead of image as drag
data, and also fixed a DCHECK.

BUG=652979
==========

to

==========
[LayoutTest] Fix debug tests and DCHECK for "inputevent-drag-drop.html"

On debug mode the tests might start before image/document is loaded.

This CL changed the tests to use styled text instead of image as drag
data, and also fixed a DCHECK.

BUG=652979
==========

[commit-bot: I haz the power, 2016-10-05 15:39:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-10-05 15:39:16]

The CQ bit was unchecked by chongz@chromium.org

[chongz, 2016-10-05 15:43:16]

Description was changed from

==========
[LayoutTest] Fix debug tests and DCHECK for "inputevent-drag-drop.html"

On debug mode the tests might start before image/document is loaded.

This CL changed the tests to use styled text instead of image as drag
data, and also fixed a DCHECK.

BUG=652979
==========

to

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as drag
data, and also fixed a DCHECK.

BUG=652979
==========

[chongz, 2016-10-05 15:46:50]

Description was changed from

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as drag
data, and also fixed a DCHECK.

BUG=652979
==========

to

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as drag
data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
==========

[chongz, 2016-10-05 15:47:21]

Description was changed from

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as drag
data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
==========

to

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
==========

[chongz, 2016-10-05 15:49:03]

chongz@chromium.org changed reviewers:
+ bokan@chromium.org, horo@chromium.org

[chongz, 2016-10-05 15:49:03]

bokan@ can you take a look at this fix for flakey test please? Thanks!

[chongz, 2016-10-05 18:41:56]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:42:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 19:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:08:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[chongz, 2016-10-05 19:47:56]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:48:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:49:11]

Dry run: This issue passed the CQ dry run.

[chongz, 2016-10-05 23:27:55]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2016-10-05 23:27:55]

yosin@ PTAL at this fix for a flakey test, thanks!

https://codereview.chromium.org/2393903003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditCommand.cpp (left):

https://codereview.chromium.org/2393903003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditCommand.cpp:106:
DCHECK(!parent || parent->isCommandGroupWrapper() ||
We don't need this anymore since the composition was cleared.

[yosin_UTC9, 2016-10-06 01:22:09]

lgtm


This patch also fixes DCHECK() in CompositionEditCommand.

https://codereview.chromium.org/2393903003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2393903003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:303:
command->m_composition = nullptr;
This is right place to fix.
I hit DCHECK(isTopLevelCommand() || !m_composition) in CompositeEditCommand dtor
running layout test.
If you run layout test --enable-leak-detection more layout test hit DCHECK in
dtor.
Anyway, thanks for fixing this!

[yosin_UTC9, 2016-10-06 01:23:00]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-06 01:23:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 01:29:59]

Description was changed from

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
==========

to

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
==========

[commit-bot: I haz the power, 2016-10-06 01:30:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 01:32:35]

Description was changed from

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979
==========

to

==========
[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG=652979

Committed: https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff
Cr-Commit-Position: refs/heads/master@{#423379}
==========

[commit-bot: I haz the power, 2016-10-06 01:32:36]

Patchset 2 (id:??) landed as
https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff
Cr-Commit-Position: refs/heads/master@{#423379}