third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2393903003: [LayoutTest] Fix flakey test "inputevent-drag-drop.html"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2393903003: [LayoutTest] Fix flakey test "inputevent-drag-drop.html" (Closed)

Patch Set: Clear composition after merging with command wrapper Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-drag-drop.html ('k') | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/EditCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index 448c3b9fda768de6bbe14a0f0d9e6b4e4a2b2c0c..a71e3fec593d8be4dfac56b78d3ea32c56a51f1f 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -300,6 +300,7 @@ void CompositeEditCommand::applyCommandToComposite(

void CompositeEditCommand::appendCommandToComposite(

CompositeEditCommand* command) {

ensureComposition()->append(command->ensureComposition());

+ command->m_composition = nullptr;

yosin_UTC9 2016/10/06 01:22:09 This is right place to fix. I hit DCHECK(isTopLeve

command->setParent(this);

m_commands.append(command);

}