Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2393853003: GN: Mark variables in nested scopes used for += and -=. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Mark variables in nested scopes used for += and -=. Previuosly GN would give an unused variable warning when you did += in an inner scope for a variable defined in an outer scope. This patch marks the outer variable used in this case. Committed: https://crrev.com/80be99d1402bc09c858868b66761d2df77f218b3 Cr-Commit-Position: refs/heads/master@{#423226}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M tools/gn/operators.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/operators_unittest.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
brettw
4 years, 2 months ago (2016-10-05 17:56:09 UTC) #2
brettw
Fix
4 years, 2 months ago (2016-10-05 18:02:23 UTC) #5
scottmg
lgtm
4 years, 2 months ago (2016-10-05 18:12:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393853003/20001
4 years, 2 months ago (2016-10-05 18:15:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 18:25:59 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 18:28:21 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80be99d1402bc09c858868b66761d2df77f218b3
Cr-Commit-Position: refs/heads/master@{#423226}

Powered by Google App Engine
This is Rietveld 408576698