Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: tools/gn/operators.cc

Issue 2393853003: GN: Mark variables in nested scopes used for += and -=. (Closed)
Patch Set: Fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/operators_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/operators.cc
diff --git a/tools/gn/operators.cc b/tools/gn/operators.cc
index 9ac18bfeff0b00cbef35f2e31bf82974927b8638..72b2dd18ce63ade447721cbc8a199c5b24699b9b 100644
--- a/tools/gn/operators.cc
+++ b/tools/gn/operators.cc
@@ -155,7 +155,7 @@ bool ValueDestination::Init(Scope* exec_scope,
const Value* ValueDestination::GetExistingValue() const {
if (type_ == SCOPE)
- return scope_->GetValue(name_token_->value(), false);
+ return scope_->GetValue(name_token_->value(), true);
else if (type_ == LIST)
return &list_->list_value()[index_];
return nullptr;
« no previous file with comments | « no previous file | tools/gn/operators_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698