Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5670)

Unified Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chromecast/browser/cast_browser_process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_browser_main_parts.cc
diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc
index 1fab3cfd1734e15f4c053d2bce6411cf6e52a9b7..6fb3f635cb07ffdea2480c45fafbed0b0d7bd169 100644
--- a/chromecast/browser/cast_browser_main_parts.cc
+++ b/chromecast/browser/cast_browser_main_parts.cc
@@ -40,6 +40,7 @@
#include "chromecast/browser/pref_service_helper.h"
#include "chromecast/browser/url_request_context_factory.h"
#include "chromecast/chromecast_features.h"
+#include "chromecast/common/global_descriptors.h"
#include "chromecast/media/base/key_systems_common.h"
#include "chromecast/media/base/media_resource_tracker.h"
#include "chromecast/media/base/video_plane_controller.h"
@@ -389,8 +390,10 @@ int CastBrowserMainParts::PreCreateThreads() {
if (!chromecast::CrashHandler::GetCrashDumpLocation(&crash_dumps_dir)) {
LOG(ERROR) << "Could not find crash dump location.";
}
- cast_browser_process_->SetCrashDumpManager(
- base::MakeUnique<breakpad::CrashDumpManager>(crash_dumps_dir));
+ breakpad::CrashDumpObserver::Create();
+ breakpad::CrashDumpObserver::GetInstance()->RegisterClient(
+ base::MakeUnique<breakpad::CrashDumpManager>(crash_dumps_dir,
+ kAndroidMinidumpDescriptor));
#else
base::FilePath home_dir;
CHECK(PathService::Get(DIR_CAST_HOME, &home_dir));
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chromecast/browser/cast_browser_process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698