Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chromecast/browser/cast_browser_main_parts.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 82c986ba706a5befa2c22cee5f9f8341d3d3312a..fd355dbc3802d419d623ea7689b8d9a1593a51e6 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2820,18 +2820,8 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&region);
mappings->ShareWithRegion(kAndroidLocalePakDescriptor, fd, region);
- if (breakpad::IsCrashReporterEnabled()) {
- base::File file =
- breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
- child_process_id);
- if (file.IsValid()) {
- mappings->Transfer(kAndroidMinidumpDescriptor,
- base::ScopedFD(file.TakePlatformFile()));
- } else {
- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
- "be disabled for this process.";
- }
- }
+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
+ child_process_id, mappings);
base::FilePath app_data_path;
PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chromecast/browser/cast_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698