Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: content/shell/browser/shell_browser_main_parts.h

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Cleanups, pre re-review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_browser_main_parts.h
diff --git a/content/shell/browser/shell_browser_main_parts.h b/content/shell/browser/shell_browser_main_parts.h
index e245404a09471fbd8bef69a16c53abe158b62e38..45e5a41674b3c54a4835a2449518387cef82bfe1 100644
--- a/content/shell/browser/shell_browser_main_parts.h
+++ b/content/shell/browser/shell_browser_main_parts.h
@@ -15,7 +15,7 @@
#if defined(OS_ANDROID)
namespace breakpad {
-class CrashDumpManager;
+class CrashDumpObserver;
}
#endif
@@ -61,9 +61,6 @@ class ShellBrowserMainParts : public BrowserMainParts {
}
private:
-#if defined(OS_ANDROID)
- std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
-#endif
std::unique_ptr<net::NetLog> net_log_;
std::unique_ptr<ShellBrowserContext> browser_context_;
std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_;
@@ -72,6 +69,10 @@ class ShellBrowserMainParts : public BrowserMainParts {
const MainFunctionParams parameters_;
bool run_message_loop_;
+#if defined(OS_ANDROID)
+ std::unique_ptr<breakpad::CrashDumpObserver> crash_dump_observer_;
+#endif
+
DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts);
};

Powered by Google App Engine
This is Rietveld 408576698